2017-06-23 15:18:40

by Dan Carpenter

Subject: [PATCH] libertas: Fix lbs_prb_rsp_limit_set()

The kstrtoul() test was reversed so this always returned -ENOTSUPP.

Fixes: 27d7f47756f4 ("net: wireless: replace strict_strtoul() with kstrtoul()")
Signed-off-by: Dan Carpenter <[email protected]>

diff --git a/drivers/net/wireless/marvell/libertas/mesh.c b/drivers/net/wireless/marvell/libertas/mesh.c
index eeeb892219aa..37ace5cb309d 100644
--- a/drivers/net/wireless/marvell/libertas/mesh.c
+++ b/drivers/net/wireless/marvell/libertas/mesh.c
@@ -233,8 +233,9 @@ static ssize_t lbs_prb_rsp_limit_set(struct device *dev,
memset(&mesh_access, 0, sizeof(mesh_access));
mesh_access.data[0] = cpu_to_le32(CMD_ACT_SET);

- if (!kstrtoul(buf, 10, &retry_limit))
- return -ENOTSUPP;
+ ret = kstrtoul(buf, 10, &retry_limit);
+ if (ret)
+ return ret;
if (retry_limit > 15)
return -ENOTSUPP;

2017-06-28 18:18:28

by Kalle Valo

Subject: Re: libertas: Fix lbs_prb_rsp_limit_set()

Dan Carpenter <[email protected]> wrote:

> The kstrtoul() test was reversed so this always returned -ENOTSUPP.
>
> Fixes: 27d7f47756f4 ("net: wireless: replace strict_strtoul() with kstrtoul()")
> Signed-off-by: Dan Carpenter <[email protected]>
> Reviewed-by: James Cameron <[email protected]>
>
> diff --git a/drivers/net/wireless/marvell/libertas/mesh.c b/drivers/net/wireless/marvell/libertas/mesh.c
> index eeeb892219aa..37ace5cb309d 100644
> --- a/drivers/net/wireless/marvell/libertas/mesh.c
> +++ b/drivers/net/wireless/marvell/libertas/mesh.c
> @@ -233,8 +233,9 @@ static ssize_t lbs_prb_rsp_limit_set(struct device *dev,
> memset(&mesh_access, 0, sizeof(mesh_access));
> mesh_access.data[0] = cpu_to_le32(CMD_ACT_SET);
>
> - if (!kstrtoul(buf, 10, &retry_limit))
> - return -ENOTSUPP;
> + ret = kstrtoul(buf, 10, &retry_limit);
> + if (ret)
> + return ret;
> if (retry_limit > 15)
> return -ENOTSUPP;

Patch applied to wireless-drivers-next.git, thanks.

69551f5f370c libertas: Fix lbs_prb_rsp_limit_set()

--
https://patchwork.kernel.org/patch/9806775/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2017-06-23 20:29:43

by James Cameron

Subject: Re: [PATCH] libertas: Fix lbs_prb_rsp_limit_set()

On Fri, Jun 23, 2017 at 06:17:38PM +0300, Dan Carpenter wrote:
> The kstrtoul() test was reversed so this always returned -ENOTSUPP.
>
> Fixes: 27d7f47756f4 ("net: wireless: replace strict_strtoul() with kstrtoul()")
> Signed-off-by: Dan Carpenter <[email protected]>

Reviewed-by: James Cameron <[email protected]>

--
James Cameron
http://quozl.netrek.org/