2017-07-03 12:28:31

by Stefan Assmann

Subject: [PATCH] rtl8723bs: fix build when DEBUG_RTL871X is defined

Defining DEBUG_RTL871X in rtw_debug.h causes the following compile error:
CC [M] drivers/staging/rtl8723bs/core/rtw_mlme.o
In file included from drivers/staging/rtl8723bs/core/rtw_mlme.c:18:0:
drivers/staging/rtl8723bs/core/rtw_mlme.c: In function ‘rtw_restruct_sec_ie’:
drivers/staging/rtl8723bs/core/rtw_mlme.c:2502:19: error: ‘ndissecuritytype’ undeclared (first use in thisfunction)

Remove the no longer existing parameter.

Signed-off-by: Stefan Assmann <[email protected]>
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index 9e35573..f97f35a 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -2498,8 +2498,7 @@ sint rtw_restruct_sec_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie, uint in
uint ndisauthmode = psecuritypriv->ndisauthtype;

RT_TRACE(_module_rtl871x_mlme_c_, _drv_notice_,
- ("+rtw_restruct_sec_ie: ndisauthmode =%d ndissecuritytype =%d\n",
- ndisauthmode, ndissecuritytype));
+ ("+rtw_restruct_sec_ie: ndisauthmode =%d\n", ndisauthmode));

/* copy fixed ie only */
memcpy(out_ie, in_ie, 12);
--
2.9.4

2017-07-04 11:01:06

by Kalle Valo

Subject: Re: [PATCH] rtl8723bs: fix build when DEBUG_RTL871X is defined

Stefan Assmann <[email protected]> writes:

> Defining DEBUG_RTL871X in rtw_debug.h causes the following compile error:
> CC [M] drivers/staging/rtl8723bs/core/rtw_mlme.o
> In file included from drivers/staging/rtl8723bs/core/rtw_mlme.c:18:0:
> drivers/staging/rtl8723bs/core/rtw_mlme.c: In function =E2=80=98rtw_restr=
uct_sec_ie=E2=80=99:
> drivers/staging/rtl8723bs/core/rtw_mlme.c:2502:19: error: =E2=80=98ndisse=
curitytype=E2=80=99 undeclared (first use in thisfunction)
>
> Remove the no longer existing parameter.
>
> Signed-off-by: Stefan Assmann <[email protected]>

Please use prefix "staging:" for staging patches.

--=20
Kalle Valo

2017-07-04 15:59:08

by Stefan Assmann

Subject: Re: [PATCH] rtl8723bs: fix build when DEBUG_RTL871X is defined

On 04.07.2017 13:01, Kalle Valo wrote:
> Stefan Assmann <[email protected]> writes:
>
>> Defining DEBUG_RTL871X in rtw_debug.h causes the following compile error:
>> CC [M] drivers/staging/rtl8723bs/core/rtw_mlme.o
>> In file included from drivers/staging/rtl8723bs/core/rtw_mlme.c:18:0:
>> drivers/staging/rtl8723bs/core/rtw_mlme.c: In function ‘rtw_restruct_sec_ie’:
>> drivers/staging/rtl8723bs/core/rtw_mlme.c:2502:19: error: ‘ndissecuritytype’ undeclared (first use in thisfunction)
>>
>> Remove the no longer existing parameter.
>>
>> Signed-off-by: Stefan Assmann <[email protected]>
>
> Please use prefix "staging:" for staging patches.
>

OK, will keep that in mind next time.
Thanks!

Stefan