2017-08-30 13:54:52

by Hans de Goede

Subject: [PATCH v2] brcmfmac: Log chip id and revision

For debugging some problems, it is useful to know the chip revision
add a brcmf_info message logging this.

Signed-off-by: Hans de Goede <[email protected]>
---
Changes in v2:
-Put the brcmf_info in brcmf_fw_map_chip_to_name() so that it works for
e.g. pcie devices too
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c
index d231042f19d6..091b52979e03 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c
@@ -601,6 +601,9 @@ int brcmf_fw_map_chip_to_name(u32 chip, u32 chiprev,
if ((nvram_name) && (mapping_table[i].nvram))
strlcat(nvram_name, mapping_table[i].nvram, BRCMF_FW_NAME_LEN);

+ brcmf_info("using %s for chip %#08x(%d) rev %#08x\n",
+ fw_name, chip, chip, chiprev);
+
return 0;
}

--
2.13.4

2017-08-30 18:49:32

by Arend Van Spriel

Subject: Re: [PATCH v2] brcmfmac: Log chip id and revision

On 30-08-17 15:54, Hans de Goede wrote:
> For debugging some problems, it is useful to know the chip revision
> add a brcmf_info message logging this.

Acked-by: Arend van Spriel <[email protected]>
> Signed-off-by: Hans de Goede <[email protected]>
> ---
> Changes in v2:
> -Put the brcmf_info in brcmf_fw_map_chip_to_name() so that it works for
> e.g. pcie devices too
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c | 3 +++
> 1 file changed, 3 insertions(+)

2017-08-31 12:59:07

by Kalle Valo

Subject: Re: [v2] brcmfmac: Log chip id and revision

Hans de Goede <[email protected]> wrote:

> For debugging some problems, it is useful to know the chip revision
> add a brcmf_info message logging this.
>
> Signed-off-by: Hans de Goede <[email protected]>
> Acked-by: Arend van Spriel <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

f38966a7ace8 brcmfmac: Log chip id and revision

--
https://patchwork.kernel.org/patch/9929651/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches