2017-12-03 21:19:37

by Vincent Legoll

Subject: Make SSB a menuconfig to ease disabling it all

The following patch makes it easier to disable all SSB config
options without entering the submenu. It will also enable one
to see that en-disabled state from the outside menu.

This is only intended to change menuconfig UI, not change
the config dependencies.

2017-12-03 21:19:40

by Vincent Legoll

Subject: [PATCH] Make SSB a menuconfig to ease disabling it all

No need to get into the submenu to disable all SSB-related config entries

Signed-off-by: Vincent Legoll <[email protected]>
---
drivers/ssb/Kconfig | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig
index d8e4219c2324..f48a2ee587a4 100644
--- a/drivers/ssb/Kconfig
+++ b/drivers/ssb/Kconfig
@@ -3,10 +3,7 @@ config SSB_POSSIBLE
depends on HAS_IOMEM && HAS_DMA
default y

-menu "Sonics Silicon Backplane"
- depends on SSB_POSSIBLE
-
-config SSB
+menuconfig SSB
tristate "Sonics Silicon Backplane support"
depends on SSB_POSSIBLE
help
@@ -21,6 +18,8 @@ config SSB

If unsure, say N.

+if SSB
+
# Common SPROM support routines
config SSB_SPROM
bool
@@ -185,4 +184,4 @@ config SSB_DRIVER_GPIO

If unsure, say N

-endmenu
+endif # SSB
--
2.11.0

2017-12-04 10:01:05

by Kalle Valo

Subject: Re: Make SSB a menuconfig to ease disabling it all

Vincent Legoll <[email protected]> writes:

> The following patch makes it easier to disable all SSB config
> options without entering the submenu. It will also enable one
> to see that en-disabled state from the outside menu.
>
> This is only intended to change menuconfig UI, not change
> the config dependencies.

So you have just oneliners as the commit log in the patch and here in
the cover letter you have a better description. As the cover letters are
not normally archived to the git repository it's better to have the
proper log in the commit log.

Also prefix the title with "ssb: " like other patches have done:

$ git log --oneline -10 drivers/ssb/
b24413180f56 License cleanup: add SPDX GPL-2.0 license identifier to files with no license
c6c092dcb21e ssb: Delete an error message for a failed memory allocation in ssb_devices_register()
8052d7245b60 ssb: Fix error routine when fallback SPROM fails
c683ffe2193b SSB: Change bare unsigned to unsigned int to suit coding style
2d4443be10a7 ssb: gpio_driver: use gpiochip data pointer
10da848f67a7 ssb: host_soc depends on sprom
b7e2d195cc52 ssb: mark ssb_bus_register as __maybe_unused
541c9a84cd85 ssb: pick SoC invariants code from MIPS BCM47xx arch
845da6e58e19 ssb: add Kconfig entry for compiling SoC related code
830c7df46247 ssb: move functions specific to SoC hosted bus to separated file

--
Kalle Valo

2017-12-07 13:45:12

by Kalle Valo

Subject: Re: ssb: make SSB a menuconfig to ease disabling it all

Vincent Legoll <[email protected]> wrote:

> No need to get into the submenu to disable all SSB-related
> config entries.
>
> This makes it easier to disable all SSB config options
> without entering the submenu. It will also enable one
> to see that en/dis-abled state from the outside menu.
>
> This is only intended to change menuconfig UI, not change
> the config dependencies.
>
> Signed-off-by: Vincent Legoll <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

8c9fdd7687d9 ssb: make SSB a menuconfig to ease disabling it all

--
https://patchwork.kernel.org/patch/10091683/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2017-12-04 22:28:00

by Vincent Legoll

Subject: [PATCH,v2] ssb: make SSB a menuconfig to ease disabling it all

Hello,

thanks for the feedback, is that better ?

2017-12-04 22:28:10

by Vincent Legoll

Subject: [PATCH] ssb: make SSB a menuconfig to ease disabling it all

No need to get into the submenu to disable all SSB-related
config entries.

This makes it easier to disable all SSB config options
without entering the submenu. It will also enable one
to see that en/dis-abled state from the outside menu.

This is only intended to change menuconfig UI, not change
the config dependencies.

Signed-off-by: Vincent Legoll <[email protected]>
---
drivers/ssb/Kconfig | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig
index d8e4219c2324..f48a2ee587a4 100644
--- a/drivers/ssb/Kconfig
+++ b/drivers/ssb/Kconfig
@@ -3,10 +3,7 @@ config SSB_POSSIBLE
depends on HAS_IOMEM && HAS_DMA
default y

-menu "Sonics Silicon Backplane"
- depends on SSB_POSSIBLE
-
-config SSB
+menuconfig SSB
tristate "Sonics Silicon Backplane support"
depends on SSB_POSSIBLE
help
@@ -21,6 +18,8 @@ config SSB

If unsure, say N.

+if SSB
+
# Common SPROM support routines
config SSB_SPROM
bool
@@ -185,4 +184,4 @@ config SSB_DRIVER_GPIO

If unsure, say N

-endmenu
+endif # SSB
--
2.11.0