2018-06-29 09:27:09

by Sergey Matyukevich

Subject: Re: [1/6] qtnfmac: implement net_device_ops callback to set MAC address

> Sergey Matyukevich <[email protected]> wrote:
>
> > From: Igor Mitsyanko <[email protected]>
> >
> > Implement net_device_ops::ndo_set_mac_address callback to allow for
> > setting interface MAC address. Implementation is done through existing
> > CHANGE_INTF firmware command. All validation is to be done by firmware.
> >
> > Signed-off-by: Igor Mitsyanko <[email protected]>
>
> 2 patches applied to wireless-drivers-next.git, thanks.
>
> ed9f34bb9d33 qtnfmac: implement net_device_ops callback to set MAC address
> 6fbef9540af0 qtnfmac: enable source MAC address randomization support

Hello Kalle,

I see the other 4 patches in this series are in 'Deferred' state. Could you
please clarify what that means. Do you have any concerns about those
remaining patches or any actions are needed from our side ?

Regards,
Sergey

2018-06-29 09:43:56

by Kalle Valo

Subject: Re: [1/6] qtnfmac: implement net_device_ops callback to set MAC address

Sergey Matyukevich <[email protected]> writes:

>> Sergey Matyukevich <[email protected]> wrote:
>>
>> > From: Igor Mitsyanko <[email protected]>
>> >
>> > Implement net_device_ops::ndo_set_mac_address callback to allow for
>> > setting interface MAC address. Implementation is done through existing
>> > CHANGE_INTF firmware command. All validation is to be done by firmware.
>> >
>> > Signed-off-by: Igor Mitsyanko <[email protected]>
>>
>> 2 patches applied to wireless-drivers-next.git, thanks.
>>
>> ed9f34bb9d33 qtnfmac: implement net_device_ops callback to set MAC address
>> 6fbef9540af0 qtnfmac: enable source MAC address randomization support
>
> Hello Kalle,
>
> I see the other 4 patches in this series are in 'Deferred' state. Could you
> please clarify what that means. Do you have any concerns about those
> remaining patches or any actions are needed from our side ?

I saw there was a comment on one patch and other patch used vendor
commands which I need to review carefully. I didn't have time at the
time so I put them to deferred and try to get back soon.

--
Kalle Valo

2018-06-29 12:03:52

by Sergey Matyukevich

Subject: Re: [1/6] qtnfmac: implement net_device_ops callback to set MAC address

> Sergey Matyukevich <[email protected]> writes:
>
> >> Sergey Matyukevich <[email protected]> wrote:
> >>
> >> > From: Igor Mitsyanko <[email protected]>
> >> >
> >> > Implement net_device_ops::ndo_set_mac_address callback to allow for
> >> > setting interface MAC address. Implementation is done through existing
> >> > CHANGE_INTF firmware command. All validation is to be done by firmware.
> >> >
> >> > Signed-off-by: Igor Mitsyanko <[email protected]>
> >>
> >> 2 patches applied to wireless-drivers-next.git, thanks.
> >>
> >> ed9f34bb9d33 qtnfmac: implement net_device_ops callback to set MAC address
> >> 6fbef9540af0 qtnfmac: enable source MAC address randomization support
> >
> > Hello Kalle,
> >
> > I see the other 4 patches in this series are in 'Deferred' state. Could you
> > please clarify what that means. Do you have any concerns about those
> > remaining patches or any actions are needed from our side ?
>
> I saw there was a comment on one patch and other patch used vendor
> commands which I need to review carefully. I didn't have time at the
> time so I put them to deferred and try to get back soon.

Ok, understood.

Regards,
Sergey