strncpy might not NUL-terminate the string, if the name equals the buffer size.
Use strlcpy instead.
Signed-off-by: Michael Buesch <[email protected]>
Cc: [email protected]
---
drivers/net/wireless/broadcom/b43legacy/leds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/b43legacy/leds.c b/drivers/net/wireless/broadcom/b43legacy/leds.c
index fd4565389c77..bc922118b6ac 100644
--- a/drivers/net/wireless/broadcom/b43legacy/leds.c
+++ b/drivers/net/wireless/broadcom/b43legacy/leds.c
@@ -101,7 +101,7 @@ static int b43legacy_register_led(struct b43legacy_wldev *dev,
led->dev = dev;
led->index = led_index;
led->activelow = activelow;
- strncpy(led->name, name, sizeof(led->name));
+ strlcpy(led->name, name, sizeof(led->name));
led->led_dev.name = led->name;
led->led_dev.default_trigger = default_trigger;
--
Michael
Michael B=C3=BCsch <[email protected]> writes:
> strncpy might not NUL-terminate the string, if the name equals the buffer=
size.
> Use strlcpy instead.
>
> Signed-off-by: Michael Buesch <[email protected]>
> Cc: [email protected]
Applied manually:
4d77a89e3924 b43legacy/leds: Ensure NUL-termination of LED name string
--=20
Kalle Valo