2018-09-03 19:23:15

by Kevin Lo

Subject: [PATCH v2] rtlwifi: remove set but unused variables

Remove set but unused variables from _rtl88ee_hw_configure() and
_rtl8723e_hw_configure().

Signed-off-by: Kevin Lo <[email protected]>
---
v2: Correct my email address.

---
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c
index 988d5ac57d02..cfc8762c55f4 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c
@@ -951,12 +951,8 @@ static bool _rtl88ee_init_mac(struct ieee80211_hw *hw)
static void _rtl88ee_hw_configure(struct ieee80211_hw *hw)
{
struct rtl_priv *rtlpriv = rtl_priv(hw);
- u8 reg_bw_opmode;
- u32 reg_ratr, reg_prsr;
+ u32 reg_prsr;

- reg_bw_opmode = BW_OPMODE_20MHZ;
- reg_ratr = RATE_ALL_CCK | RATE_ALL_OFDM_AG |
- RATE_ALL_OFDM_1SS | RATE_ALL_OFDM_2SS;
reg_prsr = RATE_ALL_CCK | RATE_ALL_OFDM_AG;

rtl_write_dword(rtlpriv, REG_RRSR, reg_prsr);
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c
index 545115db507e..f783e4a8083d 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c
@@ -799,11 +799,9 @@ static void _rtl8723e_hw_configure(struct ieee80211_hw *hw)
struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
struct rtl_priv *rtlpriv = rtl_priv(hw);
u8 reg_bw_opmode;
- u32 reg_ratr, reg_prsr;
+ u32 reg_prsr;

reg_bw_opmode = BW_OPMODE_20MHZ;
- reg_ratr = RATE_ALL_CCK | RATE_ALL_OFDM_AG |
- RATE_ALL_OFDM_1SS | RATE_ALL_OFDM_2SS;
reg_prsr = RATE_ALL_CCK | RATE_ALL_OFDM_AG;

rtl_write_byte(rtlpriv, REG_INIRTS_RATE_SEL, 0x8);

2018-09-04 06:04:33

by Ping-Ke Shih

Subject: Re: [PATCH v2] rtlwifi: remove set but unused variables

T24gTW9uLCAyMDE4LTA5LTAzIGF0IDIyOjU3ICswODAwLCBLZXZpbiBMbyB3cm90ZToNCj4gUmVt
b3ZlIHNldCBidXQgdW51c2VkIHZhcmlhYmxlcyBmcm9tIF9ydGw4OGVlX2h3X2NvbmZpZ3VyZSgp
IGFuZA0KPiBfcnRsODcyM2VfaHdfY29uZmlndXJlKCkuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBL
ZXZpbiBMbyA8a2V2bG9Aa2V2bG8ub3JnPg0KDQpBY2tlZC1ieTogUGluZy1LZSBTaGloIDxwa3No
aWhAcmVhbHRlay5jb20+DQoNCg==

2018-09-04 12:42:03

by Kalle Valo

Subject: Re: [PATCH v2] rtlwifi: remove set but unused variables

Kevin Lo <[email protected]> wrote:

> Remove set but unused variables from _rtl88ee_hw_configure() and
> _rtl8723e_hw_configure().
>
> Signed-off-by: Kevin Lo <[email protected]>
> Acked-by: Ping-Ke Shih <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

b9bcce366bd5 rtlwifi: remove set but unused variables

--
https://patchwork.kernel.org/patch/10586045/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches