On 11/5/2018 8:37 PM, Priit Laes wrote:
> Also append CORDIC_ prefix to nonprefixed macros.
Bit annoying that you made me look at LKML for this patch. Can you just
post the entire series to linux-wireless so Kalle can take it all
through his tree. Also the commit message is a bit thin. Please explain
why these are moved to the header file.
Reviewed-by: Arend van Spriel <[email protected]>
> Signed-off-by: Priit Laes <[email protected]>
> ---
> include/linux/cordic.h | 9 +++++++++
> lib/cordic.c | 23 +++++++----------------
> 2 files changed, 16 insertions(+), 16 deletions(-)
On Mon, Nov 05, 2018 at 11:02:35PM +0100, Arend van Spriel wrote:
> On 11/5/2018 8:37 PM, Priit Laes wrote:
> > Also append CORDIC_ prefix to nonprefixed macros.
>
> Bit annoying that you made me look at LKML for this patch. Can you just post
> the entire series to linux-wireless so Kalle can take it all through his
> tree. Also the commit message is a bit thin. Please explain why these are
> moved to the header file.
Sorry, I messed up again while trying to automate the send-email with
get_maintainers script (dry-run argument did not work .gitconfig :S)
>
> Reviewed-by: Arend van Spriel <[email protected]>
> > Signed-off-by: Priit Laes <[email protected]>
> > ---
> > include/linux/cordic.h | 9 +++++++++
> > lib/cordic.c | 23 +++++++----------------
> > 2 files changed, 16 insertions(+), 16 deletions(-)
>
On 11/6/2018 8:14 AM, Priit Laes wrote:
> On Mon, Nov 05, 2018 at 11:02:35PM +0100, Arend van Spriel wrote:
>> On 11/5/2018 8:37 PM, Priit Laes wrote:
>>> Also append CORDIC_ prefix to nonprefixed macros.
>>
>> Bit annoying that you made me look at LKML for this patch. Can you just post
>> the entire series to linux-wireless so Kalle can take it all through his
>> tree. Also the commit message is a bit thin. Please explain why these are
>> moved to the header file.
>
> Sorry, I messed up again while trying to automate the send-email with
> get_maintainers script (dry-run argument did not work .gitconfig :S)
No worries. It was only a bit annoying ;-)
Regards,
Arend