2018-10-23 16:13:01

by Ali MJ Al-Nasrawy

Subject: [PATCH] brcmsmac: never log "tid x is not agg'able" by default

This message greatly spams the log under heavy Tx of frames with BK access
class which is especially true when operating as AP. It is also not informative
as the "agg'ablity" of TIDs are set once and never change.
Fix this by logging only in debug mode.

Signed-off-by: Ali MJ Al-Nasrawy <[email protected]>
---
.../net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c
index 912499f..c5de9a3 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c
@@ -846,8 +846,8 @@ brcms_ops_ampdu_action(struct ieee80211_hw *hw,
status = brcms_c_aggregatable(wl->wlc, tid);
spin_unlock_bh(&wl->lock);
if (!status) {
- brcms_err(wl->wlc->hw->d11core,
- "START: tid %d is not agg\'able\n", tid);
+ brcms_dbg_ht(wl->wlc->hw->d11core,
+ "START: tid %d is not agg\'able\n", tid);
return -EINVAL;
}
ieee80211_start_tx_ba_cb_irqsafe(vif, sta->addr, tid);
--
2.19.0

2018-11-06 17:01:17

by Kalle Valo

Subject: Re: [PATCH] brcmsmac: never log "tid x is not agg'able" by default

Ali MJ Al-Nasrawy <[email protected]> wrote:

> This message greatly spams the log under heavy Tx of frames with BK access
> class which is especially true when operating as AP. It is also not informative
> as the "agg'ablity" of TIDs are set once and never change.
> Fix this by logging only in debug mode.
>
> Signed-off-by: Ali MJ Al-Nasrawy <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

96fca788e578 brcmsmac: never log "tid x is not agg'able" by default

--
https://patchwork.kernel.org/patch/10653373/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches