2018-11-18 02:59:52

by Larry Finger

Subject: [PATCH 4.20] rtlwifi: Fix leak of skb when processing C2H_BT_INFO

With commit 0a9f8f0a1ba9 ("rtlwifi: fix btmpinfo timeout while processing
C2H_BT_INFO"), calling rtl_c2hcmd_enqueue() with rtl_c2h_fast_cmd() true,
the routine returns without freeing that skb, thereby leaking it.

This issue has been discussed at https://github.com/lwfinger/rtlwifi_new/issues/401
and the fix tested there.

Fixes: 0a9f8f0a1ba9 ("rtlwifi: fix btmpinfo timeout while processing C2H_BT_INFO")
Reported-and-tested-by: Francisco Machado Magalhães Neto <[email protected]>
Cc: Francisco Machado Magalhães Neto <[email protected]>
Cc: Ping-Ke Shih <[email protected]>
Cc: Stable <[email protected]> # 4.18+
Signed-off-by: Larry Finger <[email protected]>
---
drivers/net/wireless/realtek/rtlwifi/base.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c
index f4122c8fdd97..ef9b502ce576 100644
--- a/drivers/net/wireless/realtek/rtlwifi/base.c
+++ b/drivers/net/wireless/realtek/rtlwifi/base.c
@@ -2289,6 +2289,7 @@ void rtl_c2hcmd_enqueue(struct ieee80211_hw *hw, struct sk_buff *skb)

if (rtl_c2h_fast_cmd(hw, skb)) {
rtl_c2h_content_parsing(hw, skb);
+ kfree_skb(skb);
return;
}

--
2.16.4

2018-12-13 13:39:00

by Kalle Valo

Subject: Re: [PATCH 4.20] rtlwifi: Fix leak of skb when processing C2H_BT_INFO

Larry Finger <[email protected]> wrote:

> With commit 0a9f8f0a1ba9 ("rtlwifi: fix btmpinfo timeout while processing
> C2H_BT_INFO"), calling rtl_c2hcmd_enqueue() with rtl_c2h_fast_cmd() true,
> the routine returns without freeing that skb, thereby leaking it.
>
> This issue has been discussed at https://github.com/lwfinger/rtlwifi_new/issues/401
> and the fix tested there.
>
> Fixes: 0a9f8f0a1ba9 ("rtlwifi: fix btmpinfo timeout while processing C2H_BT_INFO")
> Reported-and-tested-by: Francisco Machado Magalhães Neto <[email protected]>
> Cc: Francisco Machado Magalhães Neto <[email protected]>
> Cc: Ping-Ke Shih <[email protected]>
> Cc: Stable <[email protected]> # 4.18+
> Signed-off-by: Larry Finger <[email protected]>

Patch applied to wireless-drivers.git, thanks.

8cfa272b0d32 rtlwifi: Fix leak of skb when processing C2H_BT_INFO

--
https://patchwork.kernel.org/patch/10687671/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches