2019-01-05 08:32:26

by Július Milan

[permalink] [raw]
Subject: [PATCH] staging: wilc1000: fix cast to restricted __le32

Fixes the following sparse warnings:

drivers/staging/wilc1000/host_interface.c:2360:30: warning:
incorrect type in assignment (different base types)
expected restricted __le32 [addressable] [assigned] [usertype] frame_type
got restricted __le16 [usertype] <noident>

Fixes: 147ccfd451024 ("staging: wilc1000: handle mgmt_frame_register ops from cfg82011 context")
Signed-off-by: J?lius Milan <[email protected]>
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 5dae6e7155d3..07c3d6293573 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -2357,7 +2357,7 @@ void wilc_frame_register(struct wilc_vif *vif, u16 frame_type, bool reg)
default:
break;
}
- reg_frame.frame_type = cpu_to_le16(frame_type);
+ reg_frame.frame_type = cpu_to_le32(frame_type);
result = wilc_send_config_pkt(vif, WILC_SET_CFG, &wid, 1,
wilc_get_vif_idx(vif));
if (result)
--
2.14.5



2019-01-05 08:53:05

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] staging: wilc1000: fix cast to restricted __le32

On Sat, Jan 05, 2019 at 09:32:56AM +0100, J?lius Milan wrote:
> sorry, bad mail, see the next one please

Properly version your patches so I know what "next one" really means.

I've dropped all of these patches from my queue now, please resend with
a v2 added to the patch as the documentation says to do.

thanks,

greg k-h