2019-01-22 15:39:46

by Lorenzo Bianconi

Subject: [PATCH] mt7601u: do not use WARN_ON in the datapath

Substitute WARN_ON with WARN_ON_ONCE in mt7601u_rx_next_seg_len
routine

Signed-off-by: Lorenzo Bianconi <[email protected]>
---
drivers/net/wireless/mediatek/mt7601u/dma.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/mediatek/mt7601u/dma.c b/drivers/net/wireless/mediatek/mt7601u/dma.c
index 7f3e3983b781..f7edeffb2b19 100644
--- a/drivers/net/wireless/mediatek/mt7601u/dma.c
+++ b/drivers/net/wireless/mediatek/mt7601u/dma.c
@@ -124,9 +124,9 @@ static u16 mt7601u_rx_next_seg_len(u8 *data, u32 data_len)
u16 dma_len = get_unaligned_le16(data);

if (data_len < min_seg_len ||
- WARN_ON(!dma_len) ||
- WARN_ON(dma_len + MT_DMA_HDRS > data_len) ||
- WARN_ON(dma_len & 0x3))
+ WARN_ON_ONCE(!dma_len) ||
+ WARN_ON_ONCE(dma_len + MT_DMA_HDRS > data_len) ||
+ WARN_ON_ONCE(dma_len & 0x3))
return 0;

return MT_DMA_HDRS + dma_len;
--
2.20.1

2019-01-22 19:37:24

by Jakub Kicinski

Subject: Re: [PATCH] mt7601u: do not use WARN_ON in the datapath

On Tue, 22 Jan 2019 16:39:34 +0100, Lorenzo Bianconi wrote:
> Substitute WARN_ON with WARN_ON_ONCE in mt7601u_rx_next_seg_len
> routine
>
> Signed-off-by: Lorenzo Bianconi <[email protected]>

Acked-by: Jakub Kicinski <[email protected]>

2019-02-01 12:41:40

by Kalle Valo

Subject: Re: [PATCH] mt7601u: do not use WARN_ON in the datapath

Lorenzo Bianconi <[email protected]> wrote:

> Substitute WARN_ON with WARN_ON_ONCE in mt7601u_rx_next_seg_len
> routine
>
> Signed-off-by: Lorenzo Bianconi <[email protected]>
> Acked-by: Jakub Kicinski <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

b6958ad021c1 mt7601u: do not use WARN_ON in the datapath

--
https://patchwork.kernel.org/patch/10775829/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches