2019-05-07 02:29:08

by Tony Chuang

Subject: [PATCH 5.2 v3] rtw88: fix unassigned rssi_level in rtw_sta_info

From: Yan-Hsuan Chuang <[email protected]>

The new rssi_level should be stored in si, otherwise the rssi_level will
never be updated and get a wrong RA mask, which is calculated by the
rssi level

If a wrong RA mask is chosen, the firmware will pick some *bad rates*.
The most hurtful scene will be in *noisy environment*, such as office or
public area with many APs and users.
The latency would be high and the overall throughput would be only half
or less.

Tested in 2.4G in office area, with this patch the throughput increased
from such as "1x Mbps -> 4x Mbps".

Signed-off-by: Yan-Hsuan Chuang <[email protected]>
---
drivers/net/wireless/realtek/rtw88/phy.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtw88/phy.c b/drivers/net/wireless/realtek/rtw88/phy.c
index 4381b36..7f437e2 100644
--- a/drivers/net/wireless/realtek/rtw88/phy.c
+++ b/drivers/net/wireless/realtek/rtw88/phy.c
@@ -144,10 +144,10 @@ static void rtw_phy_stat_rssi_iter(void *data, struct ieee80211_sta *sta)
struct rtw_phy_stat_iter_data *iter_data = data;
struct rtw_dev *rtwdev = iter_data->rtwdev;
struct rtw_sta_info *si = (struct rtw_sta_info *)sta->drv_priv;
- u8 rssi, rssi_level;
+ u8 rssi;

rssi = ewma_rssi_read(&si->avg_rssi);
- rssi_level = rtw_phy_get_rssi_level(si->rssi_level, rssi);
+ si->rssi_level = rtw_phy_get_rssi_level(si->rssi_level, rssi);

rtw_fw_send_rssi_info(rtwdev, si);

--
2.7.4

2019-05-28 11:32:51

by Kalle Valo

Subject: Re: [PATCH 5.2 v3] rtw88: fix unassigned rssi_level in rtw_sta_info

<[email protected]> wrote:

> From: Yan-Hsuan Chuang <[email protected]>
>
> The new rssi_level should be stored in si, otherwise the rssi_level will
> never be updated and get a wrong RA mask, which is calculated by the
> rssi level
>
> If a wrong RA mask is chosen, the firmware will pick some *bad rates*.
> The most hurtful scene will be in *noisy environment*, such as office or
> public area with many APs and users.
> The latency would be high and the overall throughput would be only half
> or less.
>
> Tested in 2.4G in office area, with this patch the throughput increased
> from such as "1x Mbps -> 4x Mbps".
>
> Signed-off-by: Yan-Hsuan Chuang <[email protected]>

Patch applied to wireless-drivers.git, thanks.

a24bad74737f rtw88: fix unassigned rssi_level in rtw_sta_info

--
https://patchwork.kernel.org/patch/10932181/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches