2019-07-12 12:11:37

by Stanislaw Gruszka

Subject: [PATCH] mt7601u: use params->ssn value directly

There is no point to use pointer to params->ssn.

Signed-off-by: Stanislaw Gruszka <[email protected]>
---
drivers/net/wireless/mediatek/mt7601u/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/mediatek/mt7601u/main.c b/drivers/net/wireless/mediatek/mt7601u/main.c
index 89a7b1234ffb..72e608cc53af 100644
--- a/drivers/net/wireless/mediatek/mt7601u/main.c
+++ b/drivers/net/wireless/mediatek/mt7601u/main.c
@@ -351,7 +351,7 @@ mt76_ampdu_action(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
struct ieee80211_sta *sta = params->sta;
enum ieee80211_ampdu_mlme_action action = params->action;
u16 tid = params->tid;
- u16 *ssn = &params->ssn;
+ u16 ssn = params->ssn;
struct mt76_sta *msta = (struct mt76_sta *) sta->drv_priv;

WARN_ON(msta->wcid.idx > GROUP_WCID(0));
@@ -371,7 +371,7 @@ mt76_ampdu_action(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
case IEEE80211_AMPDU_TX_STOP_FLUSH_CONT:
break;
case IEEE80211_AMPDU_TX_START:
- msta->agg_ssn[tid] = *ssn << 4;
+ msta->agg_ssn[tid] = ssn << 4;
ieee80211_start_tx_ba_cb_irqsafe(vif, sta->addr, tid);
break;
case IEEE80211_AMPDU_TX_STOP_CONT:
--
2.20.1

2019-07-12 17:39:19

by Jakub Kicinski

Subject: Re: [PATCH] mt7601u: use params->ssn value directly

On Fri, 12 Jul 2019 14:09:50 +0200, Stanislaw Gruszka wrote:
> There is no point to use pointer to params->ssn.
>
> Signed-off-by: Stanislaw Gruszka <[email protected]>

Acked-by: Jakub Kicinski <[email protected]>

2019-07-24 11:53:53

by Kalle Valo

Subject: Re: [PATCH] mt7601u: use params->ssn value directly

Stanislaw Gruszka <[email protected]> wrote:

> There is no point to use pointer to params->ssn.
>
> Signed-off-by: Stanislaw Gruszka <[email protected]>
> Acked-by: Jakub Kicinski <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

f0248ec49bde mt7601u: use params->ssn value directly

--
https://patchwork.kernel.org/patch/11042213/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches