2019-07-31 21:08:58

by Adham Abozaeid

Subject: [PATCH] staging: wilc1000: remove unused function

From: Adham Abozaeid <[email protected]>

function wilc_resolve_disconnect_aberration isn't referenced, so
removing it

Signed-off-by: Adham Abozaeid <[email protected]>
---
drivers/staging/wilc1000/wilc_hif.c | 9 ---------
drivers/staging/wilc1000/wilc_hif.h | 1 -
2 files changed, 10 deletions(-)

diff --git a/drivers/staging/wilc1000/wilc_hif.c b/drivers/staging/wilc1000/wilc_hif.c
index ca252a43cd8c..4d809804c784 100644
--- a/drivers/staging/wilc1000/wilc_hif.c
+++ b/drivers/staging/wilc1000/wilc_hif.c
@@ -798,15 +798,6 @@ int wilc_disconnect(struct wilc_vif *vif)
return 0;
}

-void wilc_resolve_disconnect_aberration(struct wilc_vif *vif)
-{
- if (!vif->hif_drv)
- return;
- if (vif->hif_drv->hif_state == HOST_IF_WAITING_CONN_RESP ||
- vif->hif_drv->hif_state == HOST_IF_CONNECTING)
- wilc_disconnect(vif);
-}
-
int wilc_get_statistics(struct wilc_vif *vif, struct rf_info *stats)
{
struct wid wid_list[5];
diff --git a/drivers/staging/wilc1000/wilc_hif.h b/drivers/staging/wilc1000/wilc_hif.h
index 3bc305151651..ac5fe57f872b 100644
--- a/drivers/staging/wilc1000/wilc_hif.h
+++ b/drivers/staging/wilc1000/wilc_hif.h
@@ -222,7 +222,6 @@ void wilc_frame_register(struct wilc_vif *vif, u16 frame_type, bool reg);
int wilc_set_operation_mode(struct wilc_vif *vif, int index, u8 mode,
u8 ifc_id);
int wilc_get_statistics(struct wilc_vif *vif, struct rf_info *stats);
-void wilc_resolve_disconnect_aberration(struct wilc_vif *vif);
int wilc_get_vif_idx(struct wilc_vif *vif);
int wilc_set_tx_power(struct wilc_vif *vif, u8 tx_power);
int wilc_get_tx_power(struct wilc_vif *vif, u8 *tx_power);
--
2.17.1

2019-08-01 18:14:59

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: wilc1000: remove unused function

On Wed, Jul 31, 2019 at 09:01:20PM +0000, [email protected] wrote:
> From: Adham Abozaeid <[email protected]>
>
> function wilc_resolve_disconnect_aberration isn't referenced, so
> removing it
>
> Signed-off-by: Adham Abozaeid <[email protected]>
> ---
> drivers/staging/wilc1000/wilc_hif.c | 9 ---------
> drivers/staging/wilc1000/wilc_hif.h | 1 -
> 2 files changed, 10 deletions(-)

When you send multiple patches, with the second one depending on the
first one, always properly number them and send them as a patch series.
Please do that here when you fix up the first one and send both of these
at the same time.

thanks,

greg k-h