2019-08-13 13:38:26

by Stanislaw Gruszka

[permalink] [raw]
Subject: [PATCH 5.3] mt76: mt76x0e: disable 5GHz band for MT7630E

MT7630E hardware does support 5GHz, but we do not properly configure phy
for 5GHz channels. Scanning at this band not only do not show any APs
but also can hang the firmware.

Since vendor reference driver do not support 5GHz we don't know how
properly configure 5GHz channels. So disable this band for MT7630E .

Cc: [email protected]
Signed-off-by: Stanislaw Gruszka <[email protected]>
---
drivers/net/wireless/mediatek/mt76/mt76x0/eeprom.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/eeprom.c b/drivers/net/wireless/mediatek/mt76/mt76x0/eeprom.c
index ab6dfc026acb..36918b1bd653 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76x0/eeprom.c
+++ b/drivers/net/wireless/mediatek/mt76/mt76x0/eeprom.c
@@ -67,6 +67,11 @@ static void mt76x0_set_chip_cap(struct mt76x02_dev *dev)
dev_dbg(dev->mt76.dev, "mask out 2GHz support\n");
}

+ if (is_mt7630(dev)) {
+ dev->mt76.cap.has_5ghz = false;
+ dev_dbg(dev->mt76.dev, "mask out 5GHz support\n");
+ }
+
if (!mt76x02_field_valid(nic_conf1 & 0xff))
nic_conf1 &= 0xff00;

--
1.9.3


2019-08-14 08:54:54

by Stanislaw Gruszka

[permalink] [raw]
Subject: Re: [PATCH 5.3] mt76: mt76x0e: disable 5GHz band for MT7630E

On Tue, Aug 13, 2019 at 05:55:26PM +0000, Sasha Levin wrote:
> Hi,
>
> [This is an automated email]
>
> This commit has been processed because it contains a -stable tag.
> The stable tag indicates that it's relevant for the following trees: all
>
> The bot has tested the following trees: v5.2.8, v4.19.66, v4.14.138, v4.9.189, v4.4.189.
>
> v5.2.8: Build OK!
> v4.19.66: Failed to apply! Possible dependencies:
> 86c71d3deefa ("mt76: move eeprom utility routines in mt76x02_eeprom.h")
> d6500cf3700f ("mt76x0: add quirk to disable 2.4GHz band for Archer T1U")
> eef40d209ad0 ("mt76: move common eeprom definitions in mt76x02-lib module")
<snip>
> NOTE: The patch will not be queued to stable trees until it is upstream.
>
> How should we proceed with this patch?

mt76x0e support was added in 4.20 , so it's fine just to apply this
commit in 5.2 .

Stanislaw

2019-09-03 13:51:08

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH 5.3] mt76: mt76x0e: disable 5GHz band for MT7630E

Stanislaw Gruszka <[email protected]> wrote:

> MT7630E hardware does support 5GHz, but we do not properly configure phy
> for 5GHz channels. Scanning at this band not only do not show any APs
> but also can hang the firmware.
>
> Since vendor reference driver do not support 5GHz we don't know how
> properly configure 5GHz channels. So disable this band for MT7630E .
>
> Cc: [email protected]
> Signed-off-by: Stanislaw Gruszka <[email protected]>

Patch applied to wireless-drivers.git, thanks.

70702265a04a mt76: mt76x0e: disable 5GHz band for MT7630E

--
https://patchwork.kernel.org/patch/11092285/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches