2019-08-22 17:49:12

by Matthew Wang

[permalink] [raw]
Subject: [PATCH] nl80211: add NL80211_CMD_UPDATE_FT_IES to supported commands

Add NL80211_CMD_UPDATE_FT_IES to supported commands. In mac80211 drivers,
this can be implemented via existing NL80211_CMD_AUTHENTICATE and
NL80211_ATTR_IE, but non-mac80211 drivers have a separate command for
this. A driver supports FT if it either is mac80211 or supports this
command.

Signed-off-by: Matthew Wang <[email protected]>
Change-Id: I93e3d09a6d949466d1aea48bff2c3ad862edccc6
---
net/wireless/nl80211.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index fd05ae1437a9..c2f9e6b429b2 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -2065,6 +2065,7 @@ static int nl80211_send_wiphy(struct cfg80211_registered_device *rdev,
CMD(add_tx_ts, ADD_TX_TS);
CMD(set_multicast_to_unicast, SET_MULTICAST_TO_UNICAST);
CMD(update_connect_params, UPDATE_CONNECT_PARAMS);
+ CMD(update_ft_ies, UPDATE_FT_IES);
}
#undef CMD

--
2.23.0.187.g17f5b7556c-goog


2019-08-23 07:12:49

by Brian Norris

[permalink] [raw]
Subject: Re: [PATCH] nl80211: add NL80211_CMD_UPDATE_FT_IES to supported commands

On Thu, Aug 22, 2019 at 10:48:06AM -0700, Matthew Wang wrote:
> Add NL80211_CMD_UPDATE_FT_IES to supported commands. In mac80211 drivers,
> this can be implemented via existing NL80211_CMD_AUTHENTICATE and
> NL80211_ATTR_IE, but non-mac80211 drivers have a separate command for
> this. A driver supports FT if it either is mac80211 or supports this
> command.
>
> Signed-off-by: Matthew Wang <[email protected]>

FWIW:

Reviewed-by: Brian Norris <[email protected]>

> Change-Id: I93e3d09a6d949466d1aea48bff2c3ad862edccc6

Oops :)

2019-08-23 07:14:56

by Johannes Berg

[permalink] [raw]
Subject: Re: [PATCH] nl80211: add NL80211_CMD_UPDATE_FT_IES to supported commands

On Thu, 2019-08-22 at 11:07 -0700, Brian Norris wrote:
> On Thu, Aug 22, 2019 at 10:48:06AM -0700, Matthew Wang wrote:
> > Add NL80211_CMD_UPDATE_FT_IES to supported commands. In mac80211 drivers,
> > this can be implemented via existing NL80211_CMD_AUTHENTICATE and
> > NL80211_ATTR_IE, but non-mac80211 drivers have a separate command for
> > this. A driver supports FT if it either is mac80211 or supports this
> > command.
> >
> > Signed-off-by: Matthew Wang <[email protected]>
>
> FWIW:
>
> Reviewed-by: Brian Norris <[email protected]>
>
> > Change-Id: I93e3d09a6d949466d1aea48bff2c3ad862edccc6
>
> Oops :)

:)

No worries, I can edit that out.

johannes