2019-09-17 09:42:48

by Austin Kim

[permalink] [raw]
Subject: [PATCH] rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable

'rtstatus' local variable is not used,
so remove it for clean-up.

Signed-off-by: Austin Kim <[email protected]>
---
drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
index 54a3aec..22441dd 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
@@ -485,15 +485,12 @@ bool rtl8723e_phy_config_rf_with_headerfile(struct ieee80211_hw *hw,
enum radio_path rfpath)
{
int i;
- bool rtstatus = true;
u32 *radioa_array_table;
u16 radioa_arraylen;

radioa_arraylen = RTL8723ERADIOA_1TARRAYLENGTH;
radioa_array_table = RTL8723E_RADIOA_1TARRAY;

- rtstatus = true;
-
switch (rfpath) {
case RF90_PATH_A:
for (i = 0; i < radioa_arraylen; i = i + 2) {
--
2.6.2


2019-09-24 17:18:08

by Austin Kim

[permalink] [raw]
Subject: Re: [PATCH] rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable

Hello, Maintainers...
Would you please review above patch if you are available?

Thanks,
Austin Kim

2019년 9월 17일 (화) 오후 3:50, Austin Kim <[email protected]>님이 작성:
>
> 'rtstatus' local variable is not used,
> so remove it for clean-up.
>
> Signed-off-by: Austin Kim <[email protected]>
> ---
> drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
> index 54a3aec..22441dd 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
> @@ -485,15 +485,12 @@ bool rtl8723e_phy_config_rf_with_headerfile(struct ieee80211_hw *hw,
> enum radio_path rfpath)
> {
> int i;
> - bool rtstatus = true;
> u32 *radioa_array_table;
> u16 radioa_arraylen;
>
> radioa_arraylen = RTL8723ERADIOA_1TARRAYLENGTH;
> radioa_array_table = RTL8723E_RADIOA_1TARRAY;
>
> - rtstatus = true;
> -
> switch (rfpath) {
> case RF90_PATH_A:
> for (i = 0; i < radioa_arraylen; i = i + 2) {
> --
> 2.6.2
>

2019-09-26 00:38:35

by Ping-Ke Shih

[permalink] [raw]
Subject: RE: [PATCH] rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable


> -----Original Message-----
> From: Austin Kim [mailto:[email protected]]
> Sent: Monday, September 23, 2019 9:35 PM
> To: Pkshih; [email protected]; [email protected]
> Cc: [email protected]; [email protected]; [email protected]
> Subject: Re: [PATCH] rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable
>
> Hello, Maintainers...
> Would you please review above patch if you are available?
>

You can check status of your patch here
https://patchwork.kernel.org/project/linux-wireless/list/?series=174859
If your patch is existing in patchwork, maintainer doesn't forget it.

Another thing is to avoid top posting that makes maintainer hard to read mail.

---
PK

2019-10-01 09:21:41

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable

Austin Kim <[email protected]> wrote:

> 'rtstatus' local variable is not used,
> so remove it for clean-up.
>
> Signed-off-by: Austin Kim <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

6e7d59776311 rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable

--
https://patchwork.kernel.org/patch/11148141/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2019-10-01 11:22:20

by Austin Kim

[permalink] [raw]
Subject: Re: [PATCH] rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable

2019년 10월 1일 (화) 오후 6:20, Kalle Valo <[email protected]>님이 작성:
>
> Austin Kim <[email protected]> wrote:
>
> > 'rtstatus' local variable is not used,
> > so remove it for clean-up.
> >
> > Signed-off-by: Austin Kim <[email protected]>
>
> Patch applied to wireless-drivers-next.git, thanks.

Thanks for information.