2019-09-26 10:30:50

by Stanislaw Gruszka

Subject: [PATCH] rt2x00: initialize last_reset

Initialize last_reset variable to INITIAL_JIFFIES, otherwise it is not
possible to test H/W reset for first 5 minutes of system run.

Fixes: e403fa31ed71 ("rt2x00: add restart hw")
Reported-and-tested-by: Jonathan Liu <[email protected]>
Signed-off-by: Stanislaw Gruszka <[email protected]>
---
drivers/net/wireless/ralink/rt2x00/rt2x00debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00debug.c b/drivers/net/wireless/ralink/rt2x00/rt2x00debug.c
index 4d4e3888ef20..f2395309ec00 100644
--- a/drivers/net/wireless/ralink/rt2x00/rt2x00debug.c
+++ b/drivers/net/wireless/ralink/rt2x00/rt2x00debug.c
@@ -555,7 +555,7 @@ static ssize_t rt2x00debug_write_restart_hw(struct file *file,
{
struct rt2x00debug_intf *intf = file->private_data;
struct rt2x00_dev *rt2x00dev = intf->rt2x00dev;
- static unsigned long last_reset;
+ static unsigned long last_reset = INITIAL_JIFFIES;

if (!rt2x00_has_cap_restart_hw(rt2x00dev))
return -EOPNOTSUPP;
--
2.20.1

2019-10-01 09:10:04

by Kalle Valo

Subject: Re: [PATCH] rt2x00: initialize last_reset

Stanislaw Gruszka <[email protected]> wrote:

> Initialize last_reset variable to INITIAL_JIFFIES, otherwise it is not
> possible to test H/W reset for first 5 minutes of system run.
>
> Fixes: e403fa31ed71 ("rt2x00: add restart hw")
> Reported-and-tested-by: Jonathan Liu <[email protected]>
> Signed-off-by: Stanislaw Gruszka <[email protected]>

I'll queue this to v5.4.

--
https://patchwork.kernel.org/patch/11161981/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2019-10-02 06:41:19

by Kalle Valo

Subject: Re: [PATCH] rt2x00: initialize last_reset

Stanislaw Gruszka <[email protected]> wrote:

> Initialize last_reset variable to INITIAL_JIFFIES, otherwise it is not
> possible to test H/W reset for first 5 minutes of system run.
>
> Fixes: e403fa31ed71 ("rt2x00: add restart hw")
> Reported-and-tested-by: Jonathan Liu <[email protected]>
> Signed-off-by: Stanislaw Gruszka <[email protected]>

Patch applied to wireless-drivers.git, thanks.

c91a9cfe9f6d rt2x00: initialize last_reset

--
https://patchwork.kernel.org/patch/11161981/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches