2019-09-16 02:59:05

by Tony Chuang

Subject: [PATCH] rtw88: 8822c: fix boolreturn.cocci warnings

From: Yan-Hsuan Chuang <[email protected]>

drivers/net/wireless/realtek/rtw88/rtw8822c.c:2606:9-10: WARNING: return
of 0/1 in function 'rtw8822c_dpk_coef_iq_check' with return type bool

Return statements in functions returning bool should use true/false
instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

Fixes: 5227c2ee453d ("rtw88: 8822c: add SW DPK support")
Reported-by: kbuild test robot <[email protected]>
Signed-off-by: Yan-Hsuan Chuang <[email protected]>
---
drivers/net/wireless/realtek/rtw88/rtw8822c.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822c.c b/drivers/net/wireless/realtek/rtw88/rtw8822c.c
index c2f6cd7..084c18d 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8822c.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8822c.c
@@ -2603,9 +2603,9 @@ static bool rtw8822c_dpk_coef_iq_check(struct rtw_dev *rtwdev,
{
if (coef_i == 0x1000 || coef_i == 0x0fff ||
coef_q == 0x1000 || coef_q == 0x0fff)
- return 1;
- else
- return 0;
+ return true;
+
+ return false;
}

static u32 rtw8822c_dpk_coef_transfer(struct rtw_dev *rtwdev)
--
2.7.4

2019-10-01 09:18:54

by Kalle Valo

Subject: Re: [PATCH] rtw88: 8822c: fix boolreturn.cocci warnings

<[email protected]> wrote:

> From: Yan-Hsuan Chuang <[email protected]>
>
> drivers/net/wireless/realtek/rtw88/rtw8822c.c:2606:9-10: WARNING: return
> of 0/1 in function 'rtw8822c_dpk_coef_iq_check' with return type bool
>
> Return statements in functions returning bool should use true/false
> instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
>
> Fixes: 5227c2ee453d ("rtw88: 8822c: add SW DPK support")
> Reported-by: kbuild test robot <[email protected]>
> Signed-off-by: Yan-Hsuan Chuang <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

0d32f5d93bba rtw88: 8822c: fix boolreturn.cocci warnings

--
https://patchwork.kernel.org/patch/11146287/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches