Depending on implicit header includes, we might see this compilation
error:
.../main.h:1391:24: error: field has incomplete type 'struct tasklet_struct'
struct tasklet_struct tx_tasklet;
^
Fixes: 3745d3e550d1 ("rtw88: add driver TX queue support")
Signed-off-by: Brian Norris <[email protected]>
---
drivers/net/wireless/realtek/rtw88/main.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/realtek/rtw88/main.h b/drivers/net/wireless/realtek/rtw88/main.h
index f3eab96dba86..4759d6a0ca6e 100644
--- a/drivers/net/wireless/realtek/rtw88/main.h
+++ b/drivers/net/wireless/realtek/rtw88/main.h
@@ -11,6 +11,7 @@
#include <linux/average.h>
#include <linux/bitops.h>
#include <linux/bitfield.h>
+#include <linux/interrupt.h>
#include "util.h"
--
2.23.0.700.g56cf767bdb-goog
> Subject: [PATCH] rtw88: include interrupt.h for tasklet_struct
>
> Depending on implicit header includes, we might see this compilation
> error:
>
> .../main.h:1391:24: error: field has incomplete type 'struct tasklet_struct'
> struct tasklet_struct tx_tasklet;
> ^
>
> Fixes: 3745d3e550d1 ("rtw88: add driver TX queue support")
> Signed-off-by: Brian Norris <[email protected]>
Acked-by: Yan-Hsuan Chuang <[email protected]>
Yan-Hsuan
Brian Norris <[email protected]> wrote:
> Depending on implicit header includes, we might see this compilation
> error:
>
> .../main.h:1391:24: error: field has incomplete type 'struct tasklet_struct'
> struct tasklet_struct tx_tasklet;
> ^
>
> Fixes: 3745d3e550d1 ("rtw88: add driver TX queue support")
> Signed-off-by: Brian Norris <[email protected]>
> Acked-by: Yan-Hsuan Chuang <[email protected]>
Patch applied to wireless-drivers-next.git, thanks.
c3226d93f85c rtw88: include interrupt.h for tasklet_struct
--
https://patchwork.kernel.org/patch/11186535/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches