2019-10-23 10:55:06

by Chris Chiu

Subject: [PATCH] rtl8xxxu: fix warnings for symbol not declared.

Fix the following sparse warnings.
sparse: symbol 'rtl8723bu_set_coex_with_type' was not declared.
Should it be static?
sparse: symbol 'rtl8723bu_update_bt_link_info' was not declared.
Should it be static?
sparse: symbol 'rtl8723bu_handle_bt_inquiry' was not declared.
Should it be static?
sparse: symbol 'rtl8723bu_handle_bt_info' was not declared.
Should it be static?

Signed-off-by: Chris Chiu <[email protected]>
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
index f982f91b8bb6..eac91690772b 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
@@ -5194,6 +5194,7 @@ static void rtl8xxxu_rx_urb_work(struct work_struct *work)
* cases which Realtek doesn't provide detail for these settings. Keep
* this aligned with vendor driver for easier maintenance.
*/
+static
void rtl8723bu_set_coex_with_type(struct rtl8xxxu_priv *priv, u8 type)
{
switch (type) {
@@ -5245,6 +5246,7 @@ void rtl8723bu_set_coex_with_type(struct rtl8xxxu_priv *priv, u8 type)
}
}

+static
void rtl8723bu_update_bt_link_info(struct rtl8xxxu_priv *priv, u8 bt_info)
{
struct rtl8xxxu_btcoex *btcoex = &priv->bt_coex;
@@ -5311,6 +5313,7 @@ void rtl8723bu_update_bt_link_info(struct rtl8xxxu_priv *priv, u8 bt_info)
btcoex->bt_busy = false;
}

+static
void rtl8723bu_handle_bt_inquiry(struct rtl8xxxu_priv *priv)
{
struct ieee80211_vif *vif;
@@ -5336,6 +5339,7 @@ void rtl8723bu_handle_bt_inquiry(struct rtl8xxxu_priv *priv)
}
}

+static
void rtl8723bu_handle_bt_info(struct rtl8xxxu_priv *priv)
{
struct ieee80211_vif *vif;
--
2.20.1

2019-10-24 20:33:55

by Kalle Valo

Subject: Re: [PATCH] rtl8xxxu: fix warnings for symbol not declared

Chris Chiu <[email protected]> wrote:

> Fix the following sparse warnings.
> sparse: symbol 'rtl8723bu_set_coex_with_type' was not declared.
> Should it be static?
> sparse: symbol 'rtl8723bu_update_bt_link_info' was not declared.
> Should it be static?
> sparse: symbol 'rtl8723bu_handle_bt_inquiry' was not declared.
> Should it be static?
> sparse: symbol 'rtl8723bu_handle_bt_info' was not declared.
> Should it be static?
>
> Signed-off-by: Chris Chiu <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

b298800dd8ee rtl8xxxu: fix warnings for symbol not declared

--
https://patchwork.kernel.org/patch/11206331/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches