2019-10-25 19:29:57

by Tony Chuang

Subject: [PATCH 0/2] rtw88: fix sparse warnings

From: Yan-Hsuan Chuang <[email protected]>

Fixes sparse warnings reported by kbuild test robot

Yan-Hsuan Chuang (2):
rtw88: fix sparse warnings for DPK
rtw88: fix sparse warnings for power tracking

drivers/net/wireless/realtek/rtw88/rtw8822b.c | 2 +-
drivers/net/wireless/realtek/rtw88/rtw8822c.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)

--
2.17.1

2019-10-25 19:29:58

by Tony Chuang

Subject: [PATCH 2/2] rtw88: fix sparse warnings for power tracking

From: Yan-Hsuan Chuang <[email protected]>

sparse warnings:
drivers/net/wireless/realtek/rtw88/rtw8822b.c:1440:6: sparse: sparse:
symbol 'rtw8822b_pwr_track' was not declared. Should it be static?
drivers/net/wireless/realtek/rtw88/rtw8822c.c:1008:6: sparse: sparse:
symbol 'rtw8822c_pwrtrack_init' was not declared. Should it be static?

Fixes: c97ee3e0bea2 ("rtw88: add power tracking support")
Reported-by: kbuild test robot <[email protected]>
Signed-off-by: Yan-Hsuan Chuang <[email protected]>
---
drivers/net/wireless/realtek/rtw88/rtw8822b.c | 2 +-
drivers/net/wireless/realtek/rtw88/rtw8822c.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822b.c b/drivers/net/wireless/realtek/rtw88/rtw8822b.c
index 6f4e7326068c..3ec3e8eb3ecd 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8822b.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8822b.c
@@ -1492,7 +1492,7 @@ static void rtw8822b_phy_pwrtrack(struct rtw_dev *rtwdev)
rtw8822b_do_iqk(rtwdev);
}

-void rtw8822b_pwr_track(struct rtw_dev *rtwdev)
+static void rtw8822b_pwr_track(struct rtw_dev *rtwdev)
{
struct rtw_efuse *efuse = &rtwdev->efuse;
struct rtw_dm_info *dm_info = &rtwdev->dm_info;
diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822c.c b/drivers/net/wireless/realtek/rtw88/rtw8822c.c
index 97f4c4e1d7e9..04ced3b2a247 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8822c.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8822c.c
@@ -1006,7 +1006,7 @@ static void rtw8822c_rf_init(struct rtw_dev *rtwdev)
rtw8822c_rf_x2_check(rtwdev);
}

-void rtw8822c_pwrtrack_init(struct rtw_dev *rtwdev)
+static void rtw8822c_pwrtrack_init(struct rtw_dev *rtwdev)
{
struct rtw_dm_info *dm_info = &rtwdev->dm_info;
u8 path;
--
2.17.1

2019-10-25 19:30:52

by Tony Chuang

Subject: [PATCH 1/2] rtw88: fix sparse warnings for DPK

From: Yan-Hsuan Chuang <[email protected]>

sparse warnings:
drivers/net/wireless/realtek/rtw88/rtw8822c.c:2871:6: sparse:
sparse: symbol 'rtw8822c_dpk_cal_coef1' was not declared. Should it be
static?
drivers/net/wireless/realtek/rtw88/rtw8822c.c:3112:6: sparse:
sparse: symbol 'rtw8822c_dpk_track' was not declared. Should it be
static?

Fixes: 5227c2ee453d ("rtw88: 8822c: add SW DPK support")
Reported-by: kbuild test robot <[email protected]>
Signed-off-by: Yan-Hsuan Chuang <[email protected]>
---
drivers/net/wireless/realtek/rtw88/rtw8822c.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822c.c b/drivers/net/wireless/realtek/rtw88/rtw8822c.c
index b77905196ffb..97f4c4e1d7e9 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8822c.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8822c.c
@@ -2970,7 +2970,7 @@ static void rtw8822c_dpk_cal_gs(struct rtw_dev *rtwdev, u8 path)
dpk_info->dpk_gs[path] = tmp_gs;
}

-void rtw8822c_dpk_cal_coef1(struct rtw_dev *rtwdev)
+static void rtw8822c_dpk_cal_coef1(struct rtw_dev *rtwdev)
{
struct rtw_dpk_info *dpk_info = &rtwdev->dm_info.dpk_info;
u32 offset[DPK_RF_PATH_NUM] = {0, 0x58};
@@ -3211,7 +3211,7 @@ static void rtw8822c_phy_calibration(struct rtw_dev *rtwdev)
rtw8822c_do_dpk(rtwdev);
}

-void rtw8822c_dpk_track(struct rtw_dev *rtwdev)
+static void rtw8822c_dpk_track(struct rtw_dev *rtwdev)
{
struct rtw_dpk_info *dpk_info = &rtwdev->dm_info.dpk_info;
u8 path;
--
2.17.1

2019-10-31 08:05:57

by Kalle Valo

Subject: Re: [PATCH 1/2] rtw88: fix sparse warnings for DPK

<[email protected]> wrote:

> From: Yan-Hsuan Chuang <[email protected]>
>
> sparse warnings:
> drivers/net/wireless/realtek/rtw88/rtw8822c.c:2871:6: sparse:
> sparse: symbol 'rtw8822c_dpk_cal_coef1' was not declared. Should it be
> static?
> drivers/net/wireless/realtek/rtw88/rtw8822c.c:3112:6: sparse:
> sparse: symbol 'rtw8822c_dpk_track' was not declared. Should it be
> static?
>
> Fixes: 5227c2ee453d ("rtw88: 8822c: add SW DPK support")
> Reported-by: kbuild test robot <[email protected]>
> Signed-off-by: Yan-Hsuan Chuang <[email protected]>

2 patches applied to wireless-drivers-next.git, thanks.

1f592108bbd0 rtw88: fix sparse warnings for DPK
a969cf42e5fe rtw88: fix sparse warnings for power tracking

--
https://patchwork.kernel.org/patch/11211691/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches