2019-12-09 10:29:34

by Nicolas Cavallari

[permalink] [raw]
Subject: [RFC PATCH v1 2/4] brcmfmac: Do not allow deleting station in IBSS mode.

In preparation of allowing userspace to explicitly reset station state
in IBSS mode, reject attempts to delete stations in IBSS mode with error
EOPNOTSUPP.

Signed-off-by: Nicolas Cavallari <[email protected]>
--
I do not know if the driver could possibly support this, so take the
safe route and reject it.
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index 5598bbd09b62..5436ffd74ecb 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
@@ -4848,6 +4848,8 @@ brcmf_cfg80211_del_station(struct wiphy *wiphy, struct net_device *ndev,

if (!params->mac)
return -EFAULT;
+ if (!brcmf_is_apmode(ifp->vif))
+ return -EOPNOTSUPP;

brcmf_dbg(TRACE, "Enter %pM\n", params->mac);

--
2.24.0