2020-02-13 11:47:08

by Sergey Matyukevich

Subject: [PATCH 0/5] qtnfmac: WPA3 OWE/SAE support for AP and misc fixes

Hi Kalle and all,

This patch series includes regular portion of updates and features
for qtnfmac driver. Major change is WPA3 SAE and OWE support for AP.
Besides, there is a patch that assigns each wiphy to its own platform
device when multiple radios are provided by single PCIe function.

Regards,
Sergey

Dmitry Lebed (1):
qtnfmac: add interface combination check for repeater mode

Sergey Matyukevich (4):
qtnfmac: support WPA3 SAE in AP mode
qtnfmac: support WPA3 OWE in AP mode
qtnfmac: set valid edmg in cfg80211_chan_def
qtnfmac: assign each wiphy to its own virtual platform device

drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 53 ++++++++++++++++++---
drivers/net/wireless/quantenna/qtnfmac/commands.c | 38 ++++++++++++++-
drivers/net/wireless/quantenna/qtnfmac/commands.h | 2 +
drivers/net/wireless/quantenna/qtnfmac/core.c | 18 ++++++--
drivers/net/wireless/quantenna/qtnfmac/core.h | 5 +-
drivers/net/wireless/quantenna/qtnfmac/event.c | 54 ++++++++++++++++++++--
drivers/net/wireless/quantenna/qtnfmac/qlink.h | 33 ++++++++++++-
.../net/wireless/quantenna/qtnfmac/qlink_util.c | 2 +
8 files changed, 187 insertions(+), 18 deletions(-)

--
2.11.0

2020-02-13 11:47:11

by Sergey Matyukevich

Subject: [PATCH 3/5] qtnfmac: set valid edmg in cfg80211_chan_def

Make sure that edmg field of cfg80211_chan_def structure is properly
initialized by zeros. Otherwise cfg80211_chandef_valid may return
false if edmg fields contain some garbage.

Signed-off-by: Sergey Matyukevich <[email protected]>
---
drivers/net/wireless/quantenna/qtnfmac/qlink_util.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/net/wireless/quantenna/qtnfmac/qlink_util.c b/drivers/net/wireless/quantenna/qtnfmac/qlink_util.c
index 1a972bce7b8b..30b60d6ae546 100644
--- a/drivers/net/wireless/quantenna/qtnfmac/qlink_util.c
+++ b/drivers/net/wireless/quantenna/qtnfmac/qlink_util.c
@@ -124,6 +124,8 @@ void qlink_chandef_q2cfg(struct wiphy *wiphy,
chdef->center_freq1 = le16_to_cpu(qch->center_freq1);
chdef->center_freq2 = le16_to_cpu(qch->center_freq2);
chdef->width = qlink_chanwidth_to_nl(qch->width);
+ chdef->edmg.bw_config = 0;
+ chdef->edmg.channels = 0;
}

void qlink_chandef_cfg2q(const struct cfg80211_chan_def *chdef,
--
2.11.0

2020-02-13 11:47:50

by Sergey Matyukevich

Subject: [PATCH 5/5] qtnfmac: add interface combination check for repeater mode

From: Dmitry Lebed <[email protected]>

Firmware supports only STA as primary interface in repeater mode.
Since the only meaningful usage of AP + STA interface combination
is repeater, reject such combination with AP as primary interface.

Signed-off-by: Dmitry Lebed <[email protected]>
---
drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)

diff --git a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
index 018d3ed75fda..8be17106008d 100644
--- a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
+++ b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
@@ -102,6 +102,21 @@ qtnf_validate_iface_combinations(struct wiphy *wiphy,

ret = cfg80211_check_combinations(wiphy, &params);

+ if (ret)
+ return ret;
+
+ /* Check repeater interface combination: primary VIF should be STA only.
+ * STA (primary) + AP (secondary) is OK.
+ * AP (primary) + STA (secondary) is not supported.
+ */
+ vif = qtnf_mac_get_base_vif(mac);
+ if (vif && vif->wdev.iftype == NL80211_IFTYPE_AP &&
+ vif != change_vif && new_type == NL80211_IFTYPE_STATION) {
+ ret = -EINVAL;
+ pr_err("MAC%u invalid combination: AP as primary repeater interface is not supported\n",
+ mac->macid);
+ }
+
return ret;
}

--
2.11.0