2020-03-15 21:30:40

by Stefano Brivio

[permalink] [raw]
Subject: Re: [Outreachy kernel] [PATCH] Staging: wilc1000: cfg80211: Use kmemdup instead of kmalloc and memcpy

On Fri, 13 Mar 2020 16:54:51 +0530
Shreeya Patel <[email protected]> wrote:

> Replace calls to kmalloc followed by a memcpy with a direct call to
> kmemdup.
>
> The Coccinelle semantic patch used to make this change is as follows:
> @@
> expression from,to,size,flag;
> statement S;
> @@
>
> - to = \(kmalloc\|kzalloc\)(size,flag);
> + to = kmemdup(from,size,flag);
> if (to==NULL || ...) S
> - memcpy(to, from, size);
>
> Signed-off-by: Shreeya Patel <[email protected]>

Reviewed-by: Stefano Brivio <[email protected]>

--
Stefano