2020-04-20 12:12:00

by Jason Yan

Subject: [PATCH] ath11k: remove conversion to bool in ath11k_debug_fw_stats_process()

The '==' expression itself is bool, no need to convert it to bool again.
This fixes the following coccicheck warning:

drivers/net/wireless/ath/ath11k/debug.c:198:57-62: WARNING: conversion
to bool not needed here
drivers/net/wireless/ath/ath11k/debug.c:218:58-63: WARNING: conversion
to bool not needed here

Signed-off-by: Jason Yan <[email protected]>
---
drivers/net/wireless/ath/ath11k/debug.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath11k/debug.c b/drivers/net/wireless/ath/ath11k/debug.c
index 8d485171b0b3..69db298e16fb 100644
--- a/drivers/net/wireless/ath/ath11k/debug.c
+++ b/drivers/net/wireless/ath/ath11k/debug.c
@@ -195,7 +195,7 @@ void ath11k_debug_fw_stats_process(struct ath11k_base *ab, struct sk_buff *skb)
total_vdevs_started += ar->num_started_vdevs;
}

- is_end = ((++num_vdev) == total_vdevs_started ? true : false);
+ is_end = ((++num_vdev) == total_vdevs_started);

list_splice_tail_init(&stats.vdevs,
&ar->debug.fw_stats.vdevs);
@@ -215,7 +215,7 @@ void ath11k_debug_fw_stats_process(struct ath11k_base *ab, struct sk_buff *skb)
/* Mark end until we reached the count of all started VDEVs
* within the PDEV
*/
- is_end = ((++num_bcn) == ar->num_started_vdevs ? true : false);
+ is_end = ((++num_bcn) == ar->num_started_vdevs);

list_splice_tail_init(&stats.bcn,
&ar->debug.fw_stats.bcn);
--
2.21.1

2020-04-22 06:44:28

by Kalle Valo

Subject: Re: [PATCH] ath11k: remove conversion to bool in ath11k_debug_fw_stats_process()

Jason Yan <[email protected]> wrote:

> The '==' expression itself is bool, no need to convert it to bool again.
> This fixes the following coccicheck warning:
>
> drivers/net/wireless/ath/ath11k/debug.c:198:57-62: WARNING: conversion
> to bool not needed here
> drivers/net/wireless/ath/ath11k/debug.c:218:58-63: WARNING: conversion
> to bool not needed here
>
> Signed-off-by: Jason Yan <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

d81709346cea ath11k: remove conversion to bool in ath11k_debug_fw_stats_process()

--
https://patchwork.kernel.org/patch/11498785/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches