2020-05-04 11:35:11

by Jason Yan

Subject: [PATCH] b43: remove Comparison of 0/1 to bool variable in phy_n.c

Fix the following coccicheck warning:

drivers/net/wireless/broadcom/b43/phy_n.c:5510:19-32: WARNING:
Comparison of 0/1 to bool variable

Signed-off-by: Jason Yan <[email protected]>
---
drivers/net/wireless/broadcom/b43/phy_n.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/broadcom/b43/phy_n.c b/drivers/net/wireless/broadcom/b43/phy_n.c
index d3c001fa8eb4..c33b4235839d 100644
--- a/drivers/net/wireless/broadcom/b43/phy_n.c
+++ b/drivers/net/wireless/broadcom/b43/phy_n.c
@@ -5507,7 +5507,7 @@ static int b43_nphy_cal_tx_iq_lo(struct b43_wldev *dev,
core = (cmd & 0x3000) >> 12;
type = (cmd & 0x0F00) >> 8;

- if (phy6or5x && updated[core] == 0) {
+ if (phy6or5x && !updated[core]) {
b43_nphy_update_tx_cal_ladder(dev, core);
updated[core] = true;
}
--
2.21.1

2020-05-06 08:46:39

by Kalle Valo

Subject: Re: [PATCH] b43: remove Comparison of 0/1 to bool variable in phy_n.c

Jason Yan <[email protected]> wrote:

> Fix the following coccicheck warning:
>
> drivers/net/wireless/broadcom/b43/phy_n.c:5510:19-32: WARNING:
> Comparison of 0/1 to bool variable
>
> Signed-off-by: Jason Yan <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

e2b9ac590810 b43: remove Comparison of 0/1 to bool variable in phy_n.c

--
https://patchwork.kernel.org/patch/11525529/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches