2020-05-04 21:46:19

by Masashi Honma

Subject: [PATCH] ath9k_htc: Silence undersized packet warnings

Some devices like TP-Link TL-WN722N produces this kind of messages
frequently.

kernel: ath: phy0: Short RX data len, dropping (dlen: 4)

This warning is useful for developers to recognize that the device
(Wi-Fi dongle or USB hub etc) is noisy but not for general users. So
this patch make this warning to debug message.

Reported-By: Denis <[email protected]>
Ref: https://bugzilla.kernel.org/show_bug.cgi?id=207539
Fixes: cd486e627e67 ("ath9k_htc: Discard undersized packets")
Signed-off-by: Masashi Honma <[email protected]>
---
drivers/net/wireless/ath/ath9k/htc_drv_txrx.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
index 9cec5c216e1f..118e5550b10c 100644
--- a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
+++ b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
@@ -999,9 +999,9 @@ static bool ath9k_rx_prepare(struct ath9k_htc_priv *priv,
* which are not PHY_ERROR (short radar pulses have a length of 3)
*/
if (unlikely(!rs_datalen || (rs_datalen < 10 && !is_phyerr))) {
- ath_warn(common,
- "Short RX data len, dropping (dlen: %d)\n",
- rs_datalen);
+ ath_dbg(common, ANY,
+ "Short RX data len, dropping (dlen: %d)\n",
+ rs_datalen);
goto rx_next;
}

--
2.17.1

2020-05-06 06:25:09

by Kalle Valo

Subject: Re: [PATCH] ath9k_htc: Silence undersized packet warnings

Masashi Honma <[email protected]> wrote:

> Some devices like TP-Link TL-WN722N produces this kind of messages
> frequently.
>
> kernel: ath: phy0: Short RX data len, dropping (dlen: 4)
>
> This warning is useful for developers to recognize that the device
> (Wi-Fi dongle or USB hub etc) is noisy but not for general users. So
> this patch make this warning to debug message.
>
> Reported-By: Denis <[email protected]>
> Ref: https://bugzilla.kernel.org/show_bug.cgi?id=207539
> Fixes: cd486e627e67 ("ath9k_htc: Discard undersized packets")
> Signed-off-by: Masashi Honma <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

450edd280598 ath9k_htc: Silence undersized packet warnings

--
https://patchwork.kernel.org/patch/11527651/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches