2020-05-04 11:35:16

by Jason Yan

Subject: [PATCH] b43: remove Comparison of 0/1 to bool variable in pio.c

Fix the following coccicheck warning:

drivers/net/wireless/broadcom/b43/pio.c:768:10-25: WARNING: Comparison
of 0/1 to bool variable

Signed-off-by: Jason Yan <[email protected]>
---
drivers/net/wireless/broadcom/b43/pio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/broadcom/b43/pio.c b/drivers/net/wireless/broadcom/b43/pio.c
index 69f8b46c9015..1a11c5dfb8d9 100644
--- a/drivers/net/wireless/broadcom/b43/pio.c
+++ b/drivers/net/wireless/broadcom/b43/pio.c
@@ -765,7 +765,7 @@ void b43_pio_rx(struct b43_pio_rxqueue *q)
bool stop;

while (1) {
- stop = (pio_rx_frame(q) == 0);
+ stop = !pio_rx_frame(q);
if (stop)
break;
cond_resched();
--
2.21.1

2020-05-06 08:47:29

by Kalle Valo

Subject: Re: [PATCH] b43: remove Comparison of 0/1 to bool variable in pio.c

Jason Yan <[email protected]> wrote:

> Fix the following coccicheck warning:
>
> drivers/net/wireless/broadcom/b43/pio.c:768:10-25: WARNING: Comparison
> of 0/1 to bool variable
>
> Signed-off-by: Jason Yan <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

f8f24ece2192 b43: remove Comparison of 0/1 to bool variable in pio.c

--
https://patchwork.kernel.org/patch/11525531/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches