2020-05-08 07:48:11

by Jason Yan

Subject: [PATCH v2] brcmfmac: remove Comparison to bool in brcmf_p2p_send_action_frame()

Fix the following coccicheck warning:

drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:1785:5-8:
WARNING: Comparison to bool

Signed-off-by: Jason Yan <[email protected]>
Reviewed-by: Chi-hsien Lin <[email protected]>
---
v2: Rebased on top of wireless-drivers-next and drop one already fixed line.

drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
index e32c24a2670d..8cde31675dfb 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
@@ -1836,7 +1836,7 @@ bool brcmf_p2p_send_action_frame(struct brcmf_cfg80211_info *cfg,
dwell_overflow = brcmf_p2p_check_dwell_overflow(requested_dwell,
dwell_jiffies);
}
- if (ack == false) {
+ if (!ack) {
bphy_err(drvr, "Failed to send Action Frame(retry %d)\n",
tx_retry);
clear_bit(BRCMF_P2P_STATUS_GO_NEG_PHASE, &p2p->status);
--
2.21.1

2020-05-12 08:55:41

by Kalle Valo

Subject: Re: [PATCH v2] brcmfmac: remove Comparison to bool in brcmf_p2p_send_action_frame()

Jason Yan <[email protected]> wrote:

> Fix the following coccicheck warning:
>
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:1785:5-8:
> WARNING: Comparison to bool
>
> Signed-off-by: Jason Yan <[email protected]>
> Reviewed-by: Chi-hsien Lin <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

78a6fb42f67c brcmfmac: remove Comparison to bool in brcmf_p2p_send_action_frame()

--
https://patchwork.kernel.org/patch/11535825/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches