2020-05-12 10:36:14

by Tony Chuang

Subject: [PATCH] rtw88: 8723d: fix sparse warnings for power tracking

From: Yan-Hsuan Chuang <[email protected]>

sparse warnings: (new ones prefixed by >>)

>> drivers/net/wireless/realtek/rtw88/rtw8723d.c:1899:6: sparse: sparse:
symbol 'rtw8723d_pwr_track' was not declared. Should it be static?

Reported-by: kbuild test robot <[email protected]>
Signed-off-by: Yan-Hsuan Chuang <[email protected]>
---
drivers/net/wireless/realtek/rtw88/rtw8723d.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtw88/rtw8723d.c b/drivers/net/wireless/realtek/rtw88/rtw8723d.c
index 2a5479af092e..340c8c455802 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8723d.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8723d.c
@@ -1897,7 +1897,7 @@ static void rtw8723d_phy_pwrtrack(struct rtw_dev *rtwdev)
rtw8723d_phy_calibration(rtwdev);
}

-void rtw8723d_pwr_track(struct rtw_dev *rtwdev)
+static void rtw8723d_pwr_track(struct rtw_dev *rtwdev)
{
struct rtw_efuse *efuse = &rtwdev->efuse;
struct rtw_dm_info *dm_info = &rtwdev->dm_info;
--
2.17.1

2020-05-13 15:55:26

by Kalle Valo

Subject: Re: [PATCH] rtw88: 8723d: fix sparse warnings for power tracking

<[email protected]> wrote:

> From: Yan-Hsuan Chuang <[email protected]>
>
> sparse warnings: (new ones prefixed by >>)
>
> >> drivers/net/wireless/realtek/rtw88/rtw8723d.c:1899:6: sparse: sparse:
> symbol 'rtw8723d_pwr_track' was not declared. Should it be static?
>
> Reported-by: kbuild test robot <[email protected]>
> Signed-off-by: Yan-Hsuan Chuang <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

0c4402385ac4 rtw88: 8723d: fix sparse warnings for power tracking

--
https://patchwork.kernel.org/patch/11542931/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches