2020-05-15 21:30:28

by Luis Chamberlain

Subject: [PATCH v2 15/15] mwl8k: use new module_firmware_crashed()

This makes use of the new module_firmware_crashed() to help
annotate when firmware for device drivers crash. When firmware
crashes devices can sometimes become unresponsive, and recovery
sometimes requires a driver unload / reload and in the worst cases
a reboot.

Using a taint flag allows us to annotate when this happens clearly.

Cc: [email protected]
Cc: Lennert Buytenhek <[email protected]>
Cc: Kalle Valo <[email protected]>
Cc: "Gustavo A. R. Silva" <[email protected]>
Cc: Johannes Berg <[email protected]>
Cc: Ganapathi Bhat <[email protected]>
Signed-off-by: Luis Chamberlain <[email protected]>
---
drivers/net/wireless/marvell/mwl8k.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/marvell/mwl8k.c b/drivers/net/wireless/marvell/mwl8k.c
index 97f23f93f6e7..d609ef1bb879 100644
--- a/drivers/net/wireless/marvell/mwl8k.c
+++ b/drivers/net/wireless/marvell/mwl8k.c
@@ -1551,6 +1551,7 @@ static int mwl8k_tx_wait_empty(struct ieee80211_hw *hw)
* the firmware has crashed
*/
if (priv->hw_restart_in_progress) {
+ module_firmware_crashed();
if (priv->hw_restart_owner == current)
return 0;
else
--
2.26.2

2020-05-16 04:18:03

by Rafael Aquini

Subject: Re: [PATCH v2 15/15] mwl8k: use new module_firmware_crashed()

On Fri, May 15, 2020 at 09:28:46PM +0000, Luis Chamberlain wrote:
> This makes use of the new module_firmware_crashed() to help
> annotate when firmware for device drivers crash. When firmware
> crashes devices can sometimes become unresponsive, and recovery
> sometimes requires a driver unload / reload and in the worst cases
> a reboot.
>
> Using a taint flag allows us to annotate when this happens clearly.
>
> Cc: [email protected]
> Cc: Lennert Buytenhek <[email protected]>
> Cc: Kalle Valo <[email protected]>
> Cc: "Gustavo A. R. Silva" <[email protected]>
> Cc: Johannes Berg <[email protected]>
> Cc: Ganapathi Bhat <[email protected]>
> Signed-off-by: Luis Chamberlain <[email protected]>
> ---
> drivers/net/wireless/marvell/mwl8k.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/marvell/mwl8k.c b/drivers/net/wireless/marvell/mwl8k.c
> index 97f23f93f6e7..d609ef1bb879 100644
> --- a/drivers/net/wireless/marvell/mwl8k.c
> +++ b/drivers/net/wireless/marvell/mwl8k.c
> @@ -1551,6 +1551,7 @@ static int mwl8k_tx_wait_empty(struct ieee80211_hw *hw)
> * the firmware has crashed
> */
> if (priv->hw_restart_in_progress) {
> + module_firmware_crashed();
> if (priv->hw_restart_owner == current)
> return 0;
> else
> --
> 2.26.2
>
Acked-by: Rafael Aquini <[email protected]>