2020-05-20 05:24:26

by Tony Chuang

Subject: [PATCH 3/7] rtw88: 8821c: add dig related settings

From: Tzu-En Huang <[email protected]>

To improve user experience in field, we need DIG to adjust
RX initial gain depends on field situation. Since each chip
has its own register address, this commit defines 8821c specific
addresses.

Signed-off-by: Tzu-En Huang <[email protected]>
Signed-off-by: Yan-Hsuan Chuang <[email protected]>
---
drivers/net/wireless/realtek/rtw88/rtw8821c.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/drivers/net/wireless/realtek/rtw88/rtw8821c.c b/drivers/net/wireless/realtek/rtw88/rtw8821c.c
index ce580dace83c..df95a095df73 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8821c.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8821c.c
@@ -572,6 +572,10 @@ static const struct rtw_rfe_def rtw8821c_rfe_defs[] = {
[0] = RTW_DEF_RFE(8821c, 0, 0),
};

+static struct rtw_hw_reg rtw8821c_dig[] = {
+ [0] = { .addr = 0xc50, .mask = 0x7f },
+};
+
static const struct rtw_ltecoex_addr rtw8821c_ltecoex_addr = {
.ctrl = LTECOEX_ACCESS_CTRL,
.wdata = LTECOEX_WRITE_DATA,
@@ -653,6 +657,7 @@ struct rtw_chip_info rtw8821c_hw_spec = {
.csi_buf_pg_num = 0,
.band = RTW_BAND_2G | RTW_BAND_5G,
.page_size = 128,
+ .dig_min = 0x1c,
.ht_supported = true,
.vht_supported = true,
.lps_deep_mode_supported = BIT(LPS_DEEP_MODE_LCLK),
@@ -663,6 +668,7 @@ struct rtw_chip_info rtw8821c_hw_spec = {
.rqpn_table = rqpn_table_8821c,
.prioq_addrs = &prioq_addrs_8821c,
.intf_table = &phy_para_table_8821c,
+ .dig = rtw8821c_dig,
.rf_base_addr = {0x2800, 0x2c00},
.rf_sipi_addr = {0xc90, 0xe90},
.ltecoex_addr = &rtw8821c_ltecoex_addr,
--
2.17.1

2020-05-28 15:02:12

by Sebastian Andrzej Siewior

Subject: Re: [PATCH 3/7] rtw88: 8821c: add dig related settings

On 2020-05-20 13:23:31 [+0800], [email protected] wrote:
> From: Tzu-En Huang <[email protected]>
>
> To improve user experience in field, we need DIG to adjust
> RX initial gain depends on field situation. Since each chip
> has its own register address, this commit defines 8821c specific
> addresses.

To improve user experience in field, we need DIG to adjust RX initial
gain depends on field situation.

Define the register address for 8821c.

> Signed-off-by: Tzu-En Huang <[email protected]>
> Signed-off-by: Yan-Hsuan Chuang <[email protected]>

Sebastian