2020-05-22 03:57:14

by Tony Chuang

[permalink] [raw]
Subject: [PATCH] rtw88: 8822c: fix missing brace warning for old compilers

From: Yan-Hsuan Chuang <[email protected]>

For older versions of gcc, the array = {0}; will cause warnings:

drivers/net/wireless/realtek/rtw88/rtw8822c.c: In function 'rtw8822c_power_trim':
>> drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning:
>> missing braces around initializer [-Wmissing-braces]
s8 bb_gain[2][8] = {0};
^
drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning: (near
initialization for 'bb_gain[0]') [-Wmissing-braces]

Fixes: 5ad4d8957b69 ("rtw88: set power trim according to efuse PG values")
Reported-by: kbuild test robot <[email protected]>
Signed-off-by: Yan-Hsuan Chuang <[email protected]>
---
drivers/net/wireless/realtek/rtw88/rtw8822c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822c.c b/drivers/net/wireless/realtek/rtw88/rtw8822c.c
index 2cf1c1f0a639..c3d72ef611c6 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8822c.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8822c.c
@@ -1037,7 +1037,7 @@ static void rtw8822c_set_power_trim(struct rtw_dev *rtwdev, s8 bb_gain[2][8])
static void rtw8822c_power_trim(struct rtw_dev *rtwdev)
{
u8 pg_pwr = 0xff, i, path, idx;
- s8 bb_gain[2][8] = {0};
+ s8 bb_gain[2][8] = {};
u16 rf_efuse_2g[3] = {PPG_2GL_TXAB, PPG_2GM_TXAB, PPG_2GH_TXAB};
u16 rf_efuse_5g[2][5] = {{PPG_5GL1_TXA, PPG_5GL2_TXA, PPG_5GM1_TXA,
PPG_5GM2_TXA, PPG_5GH1_TXA},
--
2.17.1


Subject: Re: [PATCH] rtw88: 8822c: fix missing brace warning for old compilers

On 2020-05-22 11:55:21 [+0800], [email protected] wrote:
> From: Yan-Hsuan Chuang <[email protected]>
>
> For older versions of gcc, the array = {0}; will cause warnings:

I wouldn't say older. I have here 9.3.0 and it does create the same
warning.

Anyway,

Acked-by: Sebastian Andrzej Siewior <[email protected]>

Sebastian

2020-05-29 15:21:27

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] rtw88: 8822c: fix missing brace warning for old compilers

Sebastian Andrzej Siewior <[email protected]> writes:

> On 2020-05-22 11:55:21 [+0800], [email protected] wrote:
>> From: Yan-Hsuan Chuang <[email protected]>
>>
>> For older versions of gcc, the array = {0}; will cause warnings:
>
> I wouldn't say older. I have here 9.3.0 and it does create the same
> warning.

Yeah, and usually it's best to specify the exact compiler version. "old"
and "new" are very relative terms :)

--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2020-05-29 17:37:39

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] rtw88: 8822c: fix missing brace warning for old compilers

<[email protected]> wrote:

> From: Yan-Hsuan Chuang <[email protected]>
>
> For older versions of gcc, the array = {0}; will cause warnings:
>
> drivers/net/wireless/realtek/rtw88/rtw8822c.c: In function 'rtw8822c_power_trim':
> >> drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning:
> >> missing braces around initializer [-Wmissing-braces]
> s8 bb_gain[2][8] = {0};
> ^
> drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning: (near
> initialization for 'bb_gain[0]') [-Wmissing-braces]
>
> Fixes: 5ad4d8957b69 ("rtw88: set power trim according to efuse PG values")
> Reported-by: kbuild test robot <[email protected]>
> Signed-off-by: Yan-Hsuan Chuang <[email protected]>
> Acked-by: Sebastian Andrzej Siewior <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

4e1a341580f2 rtw88: 8822c: fix missing brace warning for old compilers

--
https://patchwork.kernel.org/patch/11564651/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches