2020-08-12 10:24:23

by Felix Fietkau

Subject: [PATCH 5.9] mt76: mt7615: use v1 MCU API on MT7615 to fix issues with adding/removing stations

The implementation of embedding WTBL update inside the STA_REC update is buggy
on the MT7615 v2 firmware. This leads to connection issues after a station has
connected and disconnected again.

Switch to the v1 MCU API ops, since they have received much more testing and
should be more stable.

On MT7622 and later, the v2 API is more actively used, so we should keep using
it as well.

Fixes: 6849e29ed92e ("mt76: mt7615: add starec operating flow for firmware v2")
Cc: [email protected]
Signed-off-by: Felix Fietkau <[email protected]>
---
drivers/net/wireless/mediatek/mt76/mt7615/mcu.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
index 6e869b8c5e26..59deca44d977 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
@@ -2007,7 +2007,8 @@ static int mt7615_load_n9(struct mt7615_dev *dev, const char *name)
sizeof(dev->mt76.hw->wiphy->fw_version),
"%.10s-%.15s", hdr->fw_ver, hdr->build_date);

- if (!strncmp(hdr->fw_ver, "2.0", sizeof(hdr->fw_ver))) {
+ if (!is_mt7615(&dev->mt76) &&
+ !strncmp(hdr->fw_ver, "2.0", sizeof(hdr->fw_ver))) {
dev->fw_ver = MT7615_FIRMWARE_V2;
dev->mcu_ops = &sta_update_ops;
} else {
--
2.28.0

2020-08-27 14:56:29

by Kalle Valo

Subject: Re: [PATCH 5.9] mt76: mt7615: use v1 MCU API on MT7615 to fix issues with adding/removing stations

Felix Fietkau <[email protected]> wrote:

> The implementation of embedding WTBL update inside the STA_REC update is buggy
> on the MT7615 v2 firmware. This leads to connection issues after a station has
> connected and disconnected again.
>
> Switch to the v1 MCU API ops, since they have received much more testing and
> should be more stable.
>
> On MT7622 and later, the v2 API is more actively used, so we should keep using
> it as well.
>
> Fixes: 6849e29ed92e ("mt76: mt7615: add starec operating flow for firmware v2")
> Cc: [email protected]
> Signed-off-by: Felix Fietkau <[email protected]>

Patch applied to wireless-drivers.git, thanks.

d1c9da9e4c93 mt76: mt7615: use v1 MCU API on MT7615 to fix issues with adding/removing stations

--
https://patchwork.kernel.org/patch/11710607/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches