2020-08-31 04:35:50

by Allen

Subject: [PATCH] wireless: zd1211rw: fix build warning

Tasklet conversion patches intoruced a build warning
in init_usb_rx(), this patch fixes the same.

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Allen Pais <[email protected]>
---
drivers/net/wireless/zydas/zd1211rw/zd_usb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/zydas/zd1211rw/zd_usb.c b/drivers/net/wireless/zydas/zd1211rw/zd_usb.c
index 8b3d248ba..71ec3d423 100644
--- a/drivers/net/wireless/zydas/zd1211rw/zd_usb.c
+++ b/drivers/net/wireless/zydas/zd1211rw/zd_usb.c
@@ -1178,8 +1178,9 @@ static inline void init_usb_rx(struct zd_usb *usb)
}
ZD_ASSERT(rx->fragment_length == 0);
INIT_DELAYED_WORK(&rx->idle_work, zd_rx_idle_timer_handler);
- rx->reset_timer_tasklet.func = (void (*)(unsigned long))
+ rx->reset_timer_tasklet.func = (void (*))
zd_usb_reset_rx_idle_timer_tasklet;
+ rx->reset_timer_tasklet.data = (unsigned long)&rx->reset_timer_tasklet;
}

static inline void init_usb_tx(struct zd_usb *usb)
--
2.25.1

2020-08-31 14:05:52

by Kalle Valo

Subject: Re: [PATCH] wireless: zd1211rw: fix build warning

Allen Pais <[email protected]> writes:

> Tasklet conversion patches intoruced a build warning
> in init_usb_rx(), this patch fixes the same.
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Allen Pais <[email protected]>

I'll change the title to:

zd1211rw: fix build warning

And add:

Fixes: 26721b02466e ("zd1211rw: convert tasklets to use new tasklet_setup() API")

--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2020-09-01 09:03:15

by Kalle Valo

Subject: Re: zd1211rw: fix build warning

Allen Pais <[email protected]> wrote:

> Tasklet conversion patches intoruced a build warning
> in init_usb_rx(), this patch fixes the same.
>
> Reported-by: kernel test robot <[email protected]>
> Fixes: 26721b02466e ("zd1211rw: convert tasklets to use new tasklet_setup() API")
> Signed-off-by: Allen Pais <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

5d4650ae8ba6 zd1211rw: fix build warning

--
https://patchwork.kernel.org/patch/11745469/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches