2020-09-08 06:02:35

by Wright Feng

Subject: [PATCH] cfg80211: add more comments for ap_isolate in bss_parameters

The value of struct bss_parameters::ap_isolate will be -1, 0 or 1.
The value -1 means not to change. To prevent developers from thinking
ap_isolate is only 0 or 1, I add more comments on it.

Signed-off-by: Wright Feng <[email protected]>
---
include/net/cfg80211.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
index fc7e8807838d..f60281c866dc 100644
--- a/include/net/cfg80211.h
+++ b/include/net/cfg80211.h
@@ -1764,6 +1764,7 @@ struct mpath_info {
* (or NULL for no change)
* @basic_rates_len: number of basic rates
* @ap_isolate: do not forward packets between connected stations
+ * (0 = no, 1 = yes, -1 = do not change)
* @ht_opmode: HT Operation mode
* (u16 = opmode, -1 = do not change)
* @p2p_ctwindow: P2P CT Window (-1 = no change)
--
2.25.0

2020-09-08 06:29:50

by Kalle Valo

Subject: Re: [PATCH] cfg80211: add more comments for ap_isolate in bss_parameters

Wright Feng <[email protected]> writes:

> The value of struct bss_parameters::ap_isolate will be -1, 0 or 1.
> The value -1 means not to change. To prevent developers from thinking
> ap_isolate is only 0 or 1, I add more comments on it.
>
> Signed-off-by: Wright Feng <[email protected]>

Reviewed-by: Kalle Valo <[email protected]>

--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches