2020-09-10 14:26:22

by Zheng Bin

Subject: [PATCH -next 1/3] rtlwifi: rtl8723ae: fix comparison pointer to bool warning in rf.c

Fixes coccicheck warning:

drivers/net/wireless/realtek/rtlwifi/rtl8723ae/rf.c:52:5-22: WARNING: Comparison to bool
drivers/net/wireless/realtek/rtlwifi/rtl8723ae/rf.c:482:6-14: WARNING: Comparison to bool

Signed-off-by: Zheng Bin <[email protected]>
---
drivers/net/wireless/realtek/rtlwifi/rtl8723ae/rf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/rf.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/rf.c
index ecec8c9f0992..b8ed80c84266 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/rf.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/rf.c
@@ -49,7 +49,7 @@ void rtl8723e_phy_rf6052_set_cck_txpower(struct ieee80211_hw *hw,
if (rtlefuse->eeprom_regulatory != 0)
turbo_scanoff = true;

- if (mac->act_scanning == true) {
+ if (mac->act_scanning) {
tx_agc[RF90_PATH_A] = 0x3f3f3f3f;
tx_agc[RF90_PATH_B] = 0x3f3f3f3f;

@@ -479,7 +479,7 @@ static bool _rtl8723e_phy_rf6052_config_parafile(struct ieee80211_hw *hw)
break;
}

- if (rtstatus != true) {
+ if (!rtstatus) {
rtl_dbg(rtlpriv, COMP_INIT, DBG_TRACE,
"Radio[%d] Fail!!\n", rfpath);
return false;
--
2.26.0.106.g9fadedd

2020-09-16 06:13:29

by Kalle Valo

Subject: Re: [PATCH -next 1/3] rtlwifi: rtl8723ae: fix comparison pointer to bool warning in rf.c

Zheng Bin <[email protected]> wrote:

> Fixes coccicheck warning:
>
> drivers/net/wireless/realtek/rtlwifi/rtl8723ae/rf.c:52:5-22: WARNING: Comparison to bool
> drivers/net/wireless/realtek/rtlwifi/rtl8723ae/rf.c:482:6-14: WARNING: Comparison to bool
>
> Signed-off-by: Zheng Bin <[email protected]>

3 patches applied to wireless-drivers-next.git, thanks.

4eef91a8dbce rtlwifi: rtl8723ae: fix comparison pointer to bool warning in rf.c
9d886ac4397e rtlwifi: rtl8723ae: fix comparison pointer to bool warning in trx.c
f26506f06bf8 rtlwifi: rtl8723ae: fix comparison pointer to bool warning in phy.c

--
https://patchwork.kernel.org/patch/11767923/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches