2020-09-26 17:47:04

by Alex Dewar

Subject: [PATCH] wl3501_cs: Remove unnecessary NULL check

In wl3501_detach(), link->priv is checked for a NULL value before being
passed to free_netdev(). However, it cannot be NULL at this point as it
has already been passed to other functions, so just remove the check.

Addresses-Coverity: CID 710499: Null pointer dereferences (REVERSE_INULL)
Signed-off-by: Alex Dewar <[email protected]>
---
drivers/net/wireless/wl3501_cs.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/wireless/wl3501_cs.c b/drivers/net/wireless/wl3501_cs.c
index 4e7a2140649b..026e88b80bfc 100644
--- a/drivers/net/wireless/wl3501_cs.c
+++ b/drivers/net/wireless/wl3501_cs.c
@@ -1433,9 +1433,7 @@ static void wl3501_detach(struct pcmcia_device *link)
wl3501_release(link);

unregister_netdev(dev);
-
- if (link->priv)
- free_netdev(link->priv);
+ free_netdev(dev);
}

static int wl3501_get_name(struct net_device *dev, struct iw_request_info *info,
--
2.28.0

2020-09-29 08:26:37

by Kalle Valo

Subject: Re: [PATCH] wl3501_cs: Remove unnecessary NULL check

Alex Dewar <[email protected]> wrote:

> In wl3501_detach(), link->priv is checked for a NULL value before being
> passed to free_netdev(). However, it cannot be NULL at this point as it
> has already been passed to other functions, so just remove the check.
>
> Addresses-Coverity: CID 710499: Null pointer dereferences (REVERSE_INULL)
> Signed-off-by: Alex Dewar <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

1d2a85382282 wl3501_cs: Remove unnecessary NULL check

--
https://patchwork.kernel.org/patch/11801615/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches