2020-10-11 18:10:04

by Felix Fietkau

[permalink] [raw]
Subject: [PATCH] mt76: add back the SUPPORTS_REORDERING_BUFFER flag

It was accidentally dropped while adding multiple wiphy support
Fixes fast-rx support and avoids handling reordering in both mac80211
and the driver

Cc: [email protected]
Fixes: c89d36254155 ("mt76: add function for allocating an extra wiphy")
Signed-off-by: Felix Fietkau <[email protected]>
---
drivers/net/wireless/mediatek/mt76/mac80211.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/mediatek/mt76/mac80211.c b/drivers/net/wireless/mediatek/mt76/mac80211.c
index a778ecc65261..2bc1ef1cbfea 100644
--- a/drivers/net/wireless/mediatek/mt76/mac80211.c
+++ b/drivers/net/wireless/mediatek/mt76/mac80211.c
@@ -305,6 +305,7 @@ mt76_phy_init(struct mt76_dev *dev, struct ieee80211_hw *hw)
ieee80211_hw_set(hw, SUPPORT_FAST_XMIT);
ieee80211_hw_set(hw, SUPPORTS_CLONED_SKBS);
ieee80211_hw_set(hw, SUPPORTS_AMSDU_IN_AMPDU);
+ ieee80211_hw_set(hw, SUPPORTS_REORDERING_BUFFER);

if (!(dev->drv->drv_flags & MT_DRV_AMSDU_OFFLOAD)) {
ieee80211_hw_set(hw, TX_AMSDU);
--
2.28.0


2020-10-12 02:10:17

by Lorenzo Bianconi

[permalink] [raw]
Subject: Re: [PATCH] mt76: add back the SUPPORTS_REORDERING_BUFFER flag

> It was accidentally dropped while adding multiple wiphy support
> Fixes fast-rx support and avoids handling reordering in both mac80211
> and the driver
>
> Cc: [email protected]
> Fixes: c89d36254155 ("mt76: add function for allocating an extra wiphy")
> Signed-off-by: Felix Fietkau <[email protected]>

Acked-by: Lorenzo Bianconi <[email protected]>

> ---
> drivers/net/wireless/mediatek/mt76/mac80211.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mac80211.c b/drivers/net/wireless/mediatek/mt76/mac80211.c
> index a778ecc65261..2bc1ef1cbfea 100644
> --- a/drivers/net/wireless/mediatek/mt76/mac80211.c
> +++ b/drivers/net/wireless/mediatek/mt76/mac80211.c
> @@ -305,6 +305,7 @@ mt76_phy_init(struct mt76_dev *dev, struct ieee80211_hw *hw)
> ieee80211_hw_set(hw, SUPPORT_FAST_XMIT);
> ieee80211_hw_set(hw, SUPPORTS_CLONED_SKBS);
> ieee80211_hw_set(hw, SUPPORTS_AMSDU_IN_AMPDU);
> + ieee80211_hw_set(hw, SUPPORTS_REORDERING_BUFFER);
>
> if (!(dev->drv->drv_flags & MT_DRV_AMSDU_OFFLOAD)) {
> ieee80211_hw_set(hw, TX_AMSDU);
> --
> 2.28.0
>

Attachments:
(No filename) (1.11 kB)
 signature.asc (235.00 B)
 Download all attachments