2020-11-04 11:54:48

by Stanislaw Gruszka

[permalink] [raw]
Subject: [PATCH] rt2x00: remove unused variable in rt2800_get_survey


Patch fixes this compile warning:

drivers/net/wireless/ralink/rt2x00/rt2800lib.c: In function ‘rt2800_get_survey’:
drivers/net/wireless/ralink/rt2x00/rt2800lib.c:10533:25: warning: unused variable ‘conf’ [-Wunused-variable]
10533 | struct ieee80211_conf *conf = &hw->conf;
| ^~~~

added by recent patch "rt2x00: save survey for every channel visited"

Signed-off-by: Stanislaw Gruszka <[email protected]>
---
drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
index e94c59c76559..5264b0a1f098 100644
--- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
@@ -10530,7 +10530,6 @@ int rt2800_get_survey(struct ieee80211_hw *hw, int idx,
struct survey_info *survey)
{
struct rt2x00_dev *rt2x00dev = hw->priv;
- struct ieee80211_conf *conf = &hw->conf;
struct rt2x00_chan_survey *chan_survey =
&rt2x00dev->chan_survey[idx];
enum nl80211_band band = NL80211_BAND_2GHZ;
--
2.25.4


2020-11-04 12:02:47

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] rt2x00: remove unused variable in rt2800_get_survey

Stanislaw Gruszka <[email protected]> writes:

> Patch fixes this compile warning:
>
> drivers/net/wireless/ralink/rt2x00/rt2800lib.c: In function ‘rt2800_get_survey’:
> drivers/net/wireless/ralink/rt2x00/rt2800lib.c:10533:25: warning: unused variable ‘conf’ [-Wunused-variable]
> 10533 | struct ieee80211_conf *conf = &hw->conf;
> | ^~~~
>
> added by recent patch "rt2x00: save survey for every channel visited"

You mean this one?

https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

That patch is not applied yet, so please send v3 with this patch folded
into it.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches