From: Tom Rix <[email protected]>
A followup to
https://lore.kernel.org/linux-fpga/[email protected]/
So I do not repeat this problem, add a SPDX checker for Makefiles and
Kconfigs to checkpatch.
Then treewide fix the malformed Makefiles and Kconfigs.
Those missing tags are numerous.
Kconfig has 46
Makefile has 141
Run checkpatch generally over the dirs with Makefile or Kconfig problems
to check nothing broke in checkpatch. Fix the few problems turned up
Tom Rix (7):
checkpatch: check Makefiles and Kconfigs for SPDX tag
mei: hdcp: SPDX tag should be the first line
drivers/soc/litex: fix spelling of SPDX tag
MIPS: Loongson64: fix spelling of SPDX tag
iio/scmi: fix spelling of SPDX tag
mt76: add a space between comment char and SPDX tag
mt76: use SPDX header file comment style
arch/mips/boot/dts/loongson/Makefile | 2 +-
drivers/iio/common/scmi_sensors/Makefile | 2 +-
drivers/misc/mei/hdcp/Kconfig | 1 -
drivers/net/wireless/mediatek/mt76/mt7615/Makefile | 2 +-
drivers/net/wireless/mediatek/mt76/mt7615/sdio.h | 2 +-
drivers/net/wireless/mediatek/mt76/mt7915/Makefile | 2 +-
drivers/net/wireless/mediatek/mt76/mt7915/testmode.h | 2 +-
drivers/net/wireless/mediatek/mt76/mt7921/Makefile | 2 +-
drivers/soc/litex/Kconfig | 2 +-
drivers/soc/litex/Makefile | 2 +-
scripts/checkpatch.pl | 2 +-
11 files changed, 10 insertions(+), 11 deletions(-)
--
2.26.3
From: Tom Rix <[email protected]>
checkpatch looks for SPDX-License-Identifier.
So change the '_' to '-'
Signed-off-by: Tom Rix <[email protected]>
---
drivers/soc/litex/Kconfig | 2 +-
drivers/soc/litex/Makefile | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soc/litex/Kconfig b/drivers/soc/litex/Kconfig
index e7011d665b151..c03b1f816cc08 100644
--- a/drivers/soc/litex/Kconfig
+++ b/drivers/soc/litex/Kconfig
@@ -1,4 +1,4 @@
-# SPDX-License_Identifier: GPL-2.0
+# SPDX-License-Identifier: GPL-2.0
menu "Enable LiteX SoC Builder specific drivers"
diff --git a/drivers/soc/litex/Makefile b/drivers/soc/litex/Makefile
index 98ff7325b1c07..aeae1f4165a70 100644
--- a/drivers/soc/litex/Makefile
+++ b/drivers/soc/litex/Makefile
@@ -1,3 +1,3 @@
-# SPDX-License_Identifier: GPL-2.0
+# SPDX-License-Identifier: GPL-2.0
obj-$(CONFIG_LITEX_SOC_CONTROLLER) += litex_soc_ctrl.o
--
2.26.3
From: Tom Rix <[email protected]>
checkpatch expects a space between '#' and 'SPDX...'
Add a space.
Signed-off-by: Tom Rix <[email protected]>
---
drivers/net/wireless/mediatek/mt76/mt7615/Makefile | 2 +-
drivers/net/wireless/mediatek/mt76/mt7915/Makefile | 2 +-
drivers/net/wireless/mediatek/mt76/mt7921/Makefile | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/Makefile b/drivers/net/wireless/mediatek/mt76/mt7615/Makefile
index e8fc4a7ae9bc2..83f9861ff5226 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7615/Makefile
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/Makefile
@@ -1,4 +1,4 @@
-#SPDX-License-Identifier: ISC
+# SPDX-License-Identifier: ISC
obj-$(CONFIG_MT7615_COMMON) += mt7615-common.o
obj-$(CONFIG_MT7615E) += mt7615e.o
diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/Makefile b/drivers/net/wireless/mediatek/mt76/mt7915/Makefile
index 40c8061787e94..80e49244348e2 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7915/Makefile
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/Makefile
@@ -1,4 +1,4 @@
-#SPDX-License-Identifier: ISC
+# SPDX-License-Identifier: ISC
obj-$(CONFIG_MT7915E) += mt7915e.o
diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/Makefile b/drivers/net/wireless/mediatek/mt76/mt7921/Makefile
index e531666f9fb43..0ebb59966a083 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7921/Makefile
+++ b/drivers/net/wireless/mediatek/mt76/mt7921/Makefile
@@ -1,4 +1,4 @@
-#SPDX-License-Identifier: ISC
+# SPDX-License-Identifier: ISC
obj-$(CONFIG_MT7921E) += mt7921e.o
--
2.26.3
From: Tom Rix <[email protected]>
checkpatch looks for SPDX-License-Identifier.
Remove the extra spaces.
Signed-off-by: Tom Rix <[email protected]>
---
drivers/iio/common/scmi_sensors/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/common/scmi_sensors/Makefile b/drivers/iio/common/scmi_sensors/Makefile
index f13140a2575a4..645e0fce1a739 100644
--- a/drivers/iio/common/scmi_sensors/Makefile
+++ b/drivers/iio/common/scmi_sensors/Makefile
@@ -1,4 +1,4 @@
-# SPDX - License - Identifier : GPL - 2.0 - only
+# SPDX-License-Identifier: GPL-2.0-only
#
# Makefile for the IIO over SCMI
#
--
2.26.3
From: Tom Rix <[email protected]>
header files should use '/* SPDX ... */
Change from c file comment syle to header style
Signed-off-by: Tom Rix <[email protected]>
---
drivers/net/wireless/mediatek/mt76/mt7615/sdio.h | 2 +-
drivers/net/wireless/mediatek/mt76/mt7915/testmode.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/sdio.h b/drivers/net/wireless/mediatek/mt76/mt7615/sdio.h
index 05180971de841..03877d89e1520 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7615/sdio.h
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/sdio.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: ISC
+/* SPDX-License-Identifier: ISC */
/* Copyright (C) 2020 MediaTek Inc.
*
* Author: Sean Wang <[email protected]>
diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/testmode.h b/drivers/net/wireless/mediatek/mt76/mt7915/testmode.h
index 8f8533ef9859f..397a6b5532bcc 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7915/testmode.h
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/testmode.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: ISC
+/* SPDX-License-Identifier: ISC */
/* Copyright (C) 2020 MediaTek Inc. */
#ifndef __MT7915_TESTMODE_H
--
2.26.3
On Thu, 10 Jun 2021 14:44:36 -0700
[email protected] wrote:
> From: Tom Rix <[email protected]>
>
> checkpatch looks for SPDX-License-Identifier.
> Remove the extra spaces.
>
> Signed-off-by: Tom Rix <[email protected]>
Applied this one to the togreg branch of iio.git (initially pushed out as testing
to let 0-day have first poke at it). Thanks,
Jonathan
> ---
> drivers/iio/common/scmi_sensors/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/common/scmi_sensors/Makefile b/drivers/iio/common/scmi_sensors/Makefile
> index f13140a2575a4..645e0fce1a739 100644
> --- a/drivers/iio/common/scmi_sensors/Makefile
> +++ b/drivers/iio/common/scmi_sensors/Makefile
> @@ -1,4 +1,4 @@
> -# SPDX - License - Identifier : GPL - 2.0 - only
> +# SPDX-License-Identifier: GPL-2.0-only
> #
> # Makefile for the IIO over SCMI
> #
On Thu, Jun 10, 2021 at 02:44:34PM -0700, [email protected] wrote:
> From: Tom Rix <[email protected]>
>
> checkpatch looks for SPDX-License-Identifier.
> So change the '_' to '-'
>
> Signed-off-by: Tom Rix <[email protected]>
Acked-by: Stafford Horne <[email protected]>
> ---
> drivers/soc/litex/Kconfig | 2 +-
> drivers/soc/litex/Makefile | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/litex/Kconfig b/drivers/soc/litex/Kconfig
> index e7011d665b151..c03b1f816cc08 100644
> --- a/drivers/soc/litex/Kconfig
> +++ b/drivers/soc/litex/Kconfig
> @@ -1,4 +1,4 @@
> -# SPDX-License_Identifier: GPL-2.0
> +# SPDX-License-Identifier: GPL-2.0
>
> menu "Enable LiteX SoC Builder specific drivers"
>
> diff --git a/drivers/soc/litex/Makefile b/drivers/soc/litex/Makefile
> index 98ff7325b1c07..aeae1f4165a70 100644
> --- a/drivers/soc/litex/Makefile
> +++ b/drivers/soc/litex/Makefile
> @@ -1,3 +1,3 @@
> -# SPDX-License_Identifier: GPL-2.0
> +# SPDX-License-Identifier: GPL-2.0
>
> obj-$(CONFIG_LITEX_SOC_CONTROLLER) += litex_soc_ctrl.o
> --
> 2.26.3
>