2021-08-12 18:26:10

by Angus Ainslie

Subject: [PATCH v3 2/2] btbcm: add patch ram for bluetooth

Bluetooth on the BCM43752 needs a patchram file to function correctly.

Signed-off-by: Angus Ainslie <[email protected]>
---
drivers/bluetooth/btbcm.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
index e5d706ed55ea..e4182acee488 100644
--- a/drivers/bluetooth/btbcm.c
+++ b/drivers/bluetooth/btbcm.c
@@ -387,6 +387,7 @@ struct bcm_subver_table {
};

static const struct bcm_subver_table bcm_uart_subver_table[] = {
+ { 0x1111, "BCM4362A2" }, /* 000.017.017 */
{ 0x4103, "BCM4330B1" }, /* 002.001.003 */
{ 0x410d, "BCM4334B0" }, /* 002.001.013 */
{ 0x410e, "BCM43341B0" }, /* 002.001.014 */
--
2.25.1

2021-08-16 15:59:06

by Marcel Holtmann

Subject: Re: [PATCH v3 2/2] btbcm: add patch ram for bluetooth

Hi Angus,

> Bluetooth on the BCM43752 needs a patchram file to function correctly.
>
> Signed-off-by: Angus Ainslie <[email protected]>
> ---
> drivers/bluetooth/btbcm.c | 1 +
> 1 file changed, 1 insertion(+)

patch has been applied to bluetooth-next tree.

Regards

Marcel

2021-08-16 21:59:11

by Arend Van Spriel

Subject: Re: [PATCH v3 2/2] btbcm: add patch ram for bluetooth

On 8/12/2021 6:52 PM, Angus Ainslie wrote:
> Bluetooth on the BCM43752 needs a patchram file to function correctly.
>
> Signed-off-by: Angus Ainslie <[email protected]>
> ---
> drivers/bluetooth/btbcm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
> index e5d706ed55ea..e4182acee488 100644
> --- a/drivers/bluetooth/btbcm.c
> +++ b/drivers/bluetooth/btbcm.c
> @@ -387,6 +387,7 @@ struct bcm_subver_table {
> };
>
> static const struct bcm_subver_table bcm_uart_subver_table[] = {
> + { 0x1111, "BCM4362A2" }, /* 000.017.017 */

Noticed Marcel applied this one already, but as I asked in earlier patch
I would like to know why the commit message says 43752 but this entry
says 4362? Still confused.

Regards,
Arend

2021-08-19 15:44:02

by Arend Van Spriel

Subject: Re: [PATCH v3 2/2] btbcm: add patch ram for bluetooth

On August 19, 2021 5:26:42 PM Marcel Holtmann <[email protected]> wrote:

> Hi Arend,
>
>>> Bluetooth on the BCM43752 needs a patchram file to function correctly.
>>> Signed-off-by: Angus Ainslie <[email protected]>
>>> ---
>>> drivers/bluetooth/btbcm.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>> diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
>>> index e5d706ed55ea..e4182acee488 100644
>>> --- a/drivers/bluetooth/btbcm.c
>>> +++ b/drivers/bluetooth/btbcm.c
>>> @@ -387,6 +387,7 @@ struct bcm_subver_table {
>>> };
>>> static const struct bcm_subver_table bcm_uart_subver_table[] = {
>>> + { 0x1111, "BCM4362A2" }, /* 000.017.017 */
>>
>> Noticed Marcel applied this one already, but as I asked in earlier patch I
>> would like to know why the commit message says 43752 but this entry says
>> 4362? Still confused.
>
> seems I missed that part. Can you look internally what this hardware is and
> we fix it?

I will check although not internally as this is probably a Cypress chipset.
Anyway, I will follow up on this.

Regards,
Arend