2021-08-19 20:50:38

by Ben Greear

[permalink] [raw]
Subject: [PATCH v8 4/9] mt76: mt7915: allow processing TXS for 'NO_SKB' pkt-ids

From: Ben Greear <[email protected]>

This will let us update stats and wcid.rate for every TXS
callback we receive for a particular wcid.

For now, the TXS is not requested for NO_SKB frames, however.
That will be allowed in next patch.

Signed-off-by: Ben Greear <[email protected]>
---
drivers/net/wireless/mediatek/mt76/mt7915/mac.c | 17 ++++++++++++-----
1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c
index 6f92e207680f..f6ed5d5febb7 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c
@@ -1430,10 +1430,16 @@ mt7915_mac_add_txs_skb(struct mt7915_dev *dev, struct mt76_wcid *wcid, int pid,
* paired with TXS data. This is normal datapath.
*/
struct rate_info *rate = &wcid->rate;
- struct sk_buff *skb;
+ struct sk_buff *skb = NULL;
+ bool check_status;

- mt76_tx_status_lock(mdev, &list);
- skb = mt76_tx_status_skb_get(mdev, wcid, pid, &list);
+ check_status = ((pid >= MT_PACKET_ID_FIRST) ||
+ time_after(jiffies, mdev->next_status_jiffies));
+
+ if (check_status) {
+ mt76_tx_status_lock(mdev, &list);
+ skb = mt76_tx_status_skb_get(mdev, wcid, pid, &list);
+ }

memset(rate, 0, sizeof(*rate));

@@ -1447,7 +1453,8 @@ mt7915_mac_add_txs_skb(struct mt7915_dev *dev, struct mt76_wcid *wcid, int pid,
if (skb)
mt76_tx_status_skb_done(mdev, skb, &list, wcid);

- mt76_tx_status_unlock(mdev, &list);
+ if (check_status)
+ mt76_tx_status_unlock(mdev, &list);
}

static void mt7915_mac_add_txs(struct mt7915_dev *dev, void *data)
@@ -1469,7 +1476,7 @@ static void mt7915_mac_add_txs(struct mt7915_dev *dev, void *data)
txs = le32_to_cpu(txs_data[3]);
pid = FIELD_GET(MT_TXS3_PID, txs);

- if (pid < MT_PACKET_ID_FIRST)
+ if (pid < MT_PACKET_ID_NO_SKB)
return;

if (wcidx >= MT7915_WTBL_SIZE)
--
2.20.1