2021-08-21 21:12:33

by Larry Finger

Subject: [PATCH v2] rtw88: add quirk to disable pci caps on HP Pavilion 14-ce0xxx

From: Ugo Rémery <[email protected]>

8821CE causes random freezes on HP Pavilion 14-ce0019nf. Add a quirk
to disable pci ASPM capability.

Signed-off-by: Larry Finger <[email protected]>
---
v2 - add s-o-b line
---
drivers/net/wireless/realtek/rtw88/pci.c | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/drivers/net/wireless/realtek/rtw88/pci.c b/drivers/net/wireless/realtek/rtw88/pci.c
index e7d17ab8f113..31ee859d379b 100644
--- a/drivers/net/wireless/realtek/rtw88/pci.c
+++ b/drivers/net/wireless/realtek/rtw88/pci.c
@@ -1701,6 +1701,15 @@ static const struct dmi_system_id rtw88_pci_quirks[] = {
},
.driver_data = (void *)BIT(QUIRK_DIS_PCI_CAP_ASPM),
},
+ {
+ .callback = disable_pci_caps,
+ .ident = "HP HP Pavilion Laptop 14-ce0xxx",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "HP"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion Laptop 14-ce0xxx"),
+ },
+ .driver_data = (void *)BIT(QUIRK_DIS_PCI_CAP_ASPM),
+ },
{}
};

--
2.32.0

2021-08-22 05:11:11

by Kalle Valo

Subject: Re: [PATCH v2] rtw88: add quirk to disable pci caps on HP Pavilion 14-ce0xxx

Larry Finger <[email protected]> writes:

> From: Ugo Rémery <[email protected]>
>
> 8821CE causes random freezes on HP Pavilion 14-ce0019nf. Add a quirk
> to disable pci ASPM capability.
>
> Signed-off-by: Larry Finger <[email protected]>

If Ugo wrote this (which I assume he did as he is marked as the author
in the from line) his s-o-b is also needed. The order of s-o-b should be
first the author's (Ugo) and then the submitter's (Larry).

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#signed-off-by_missing

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches