This replaces the existing .txt binding file. Furthermore, this
also helps with validating DTS files.
Introduced binding changes:
1. added inherited mac-address nvmem property
2. added inherited ieee80211-freq-limit property
3. added new calibration nvmem property
Added binding .yaml to MAINTAINERS.
Signed-off-by: Christian Lamparter <[email protected]>
---
Q: Is there a way to encode the pci-id device value to the
specific chip? This is because the qca,ath9k.txt had this
nice list:
- 002e for AR9287
- 0030 for AR9380, AR9381 and AR9382
- 0032 for AR9485
I would like to preserve this information.
Thanks,
Christian
---
.../bindings/net/wireless/qca,ath9k.txt | 48 -----------
.../bindings/net/wireless/qca,ath9k.yaml | 82 +++++++++++++++++++
MAINTAINERS | 1 +
3 files changed, 83 insertions(+), 48 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/net/wireless/qca,ath9k.txt
create mode 100644 Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
diff --git a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.txt b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.txt
deleted file mode 100644
index aaaeeb5f935b..000000000000
--- a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.txt
+++ /dev/null
@@ -1,48 +0,0 @@
-* Qualcomm Atheros ath9k wireless devices
-
-This node provides properties for configuring the ath9k wireless device. The
-node is expected to be specified as a child node of the PCI controller to
-which the wireless chip is connected.
-
-Required properties:
-- compatible: For PCI and PCIe devices this should be an identifier following
- the format as defined in "PCI Bus Binding to Open Firmware"
- Revision 2.1. One of the possible formats is "pciVVVV,DDDD"
- where VVVV is the PCI vendor ID and DDDD is PCI device ID.
- Typically QCA's PCI vendor ID 168c is used while the PCI device
- ID depends on the chipset - see the following (possibly
- incomplete) list:
- - 0023 for AR5416
- - 0024 for AR5418
- - 0027 for AR9160
- - 0029 for AR9220 and AR9223
- - 002a for AR9280 and AR9283
- - 002b for AR9285
- - 002c for AR2427
- - 002d for AR9227
- - 002e for AR9287
- - 0030 for AR9380, AR9381 and AR9382
- - 0032 for AR9485
- - 0033 for AR9580 and AR9590
- - 0034 for AR9462
- - 0036 for AR9565
- - 0037 for AR9485
-- reg: Address and length of the register set for the device.
-
-Optional properties:
-- qca,no-eeprom: Indicates that there is no physical EEPROM connected to the
- ath9k wireless chip (in this case the calibration /
- EEPROM data will be loaded from userspace using the
- kernel firmware loader).
-
-The MAC address will be determined using the optional properties defined in
-net/ethernet.txt.
-
-In this example, the node is defined as child node of the PCI controller:
-&pci0 {
- wifi@168c,002d {
- compatible = "pci168c,002d";
- reg = <0x7000 0 0 0 0x1000>;
- qca,no-eeprom;
- };
-};
diff --git a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
new file mode 100644
index 000000000000..af00105f39c7
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
@@ -0,0 +1,82 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/wireless/qca,ath9k.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Atheros ath9k wireless devices Generic Binding
+
+maintainers:
+ - Kalle Valo <[email protected]>
+
+description: |
+ This node provides properties for configuring the ath9k wireless device.
+ The node is expected to be specified as a child node of the PCI controller
+ to which the wireless chip is connected.
+
+allOf:
+ - $ref: ieee80211.yaml#
+
+properties:
+ compatible:
+ enum:
+ - pci168c,0023
+ - pci168c,0024
+ - pci168c,0027
+ - pci168c,0029
+ - pci168c,002a
+ - pci168c,002b
+ - pci168c,002c
+ - pci168c,002d
+ - pci168c,002e
+ - pci168c,0030
+ - pci168c,0032
+ - pci168c,0033
+ - pci168c,0034
+ - pci168c,0036
+ - pci168c,0037
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ ieee80211-freq-limit: true
+
+ qca,no-eeprom:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description:
+ Indicates that there is no physical EEPROM connected
+
+ nvmem-cells:
+ items:
+ - description: Reference to an nvmem node for the MAC address
+ - description: Reference to an nvmem node for calibration data
+
+ nvmem-cell-names:
+ items:
+ - const: mac-address
+ - const: calibration
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ pcie0 {
+ #address-cells = <3>;
+ #size-cells = <2>;
+ wifi@0,0 {
+ compatible = "pci168c,002d";
+ reg = <0 0 0 0 0>;
+ interrupts = <3>;
+ qca,no-eeprom;
+
+ nvmem-cells = <&macaddr_art_c>, <&cal_art_1000>;
+ nvmem-cell-names = "mac-address", "calibration";
+ };
+ };
diff --git a/MAINTAINERS b/MAINTAINERS
index 6abfd3e36c31..5b42798637a3 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -15346,6 +15346,7 @@ M: [email protected]
L: [email protected]
S: Supported
W: https://wireless.wiki.kernel.org/en/users/Drivers/ath9k
+F: Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
F: drivers/net/wireless/ath/ath9k/
QUALCOMM CAMERA SUBSYSTEM DRIVER
--
2.33.0
On Fri, Sep 17, 2021 at 06:46:36PM +0200, Christian Lamparter wrote:
> This replaces the existing .txt binding file. Furthermore, this
> also helps with validating DTS files.
>
> Introduced binding changes:
> 1. added inherited mac-address nvmem property
> 2. added inherited ieee80211-freq-limit property
> 3. added new calibration nvmem property
>
> Added binding .yaml to MAINTAINERS.
>
> Signed-off-by: Christian Lamparter <[email protected]>
> ---
>
> Q: Is there a way to encode the pci-id device value to the
> specific chip? This is because the qca,ath9k.txt had this
> nice list:
> - 002e for AR9287
> - 0030 for AR9380, AR9381 and AR9382
> - 0032 for AR9485
You can add a comment after each compatible value.
>
> I would like to preserve this information.
>
> Thanks,
> Christian
>
> ---
> .../bindings/net/wireless/qca,ath9k.txt | 48 -----------
> .../bindings/net/wireless/qca,ath9k.yaml | 82 +++++++++++++++++++
> MAINTAINERS | 1 +
> 3 files changed, 83 insertions(+), 48 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/net/wireless/qca,ath9k.txt
> create mode 100644 Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
Reviewed-by: Rob Herring <[email protected]>