From: Colin Ian King <[email protected]>
The variable version is being initialized with a value that is
never read, it is being updated afterwards in both branches of
an if statement. The assignment is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/hw.c
index 88fa2e593fef..76189283104c 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/hw.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/hw.c
@@ -1430,7 +1430,7 @@ static enum version_8192e _rtl92ee_read_chip_version(struct ieee80211_hw *hw)
{
struct rtl_priv *rtlpriv = rtl_priv(hw);
struct rtl_phy *rtlphy = &rtlpriv->phy;
- enum version_8192e version = VERSION_UNKNOWN;
+ enum version_8192e version;
u32 value32;
rtlphy->rf_type = RF_2T2R;
--
2.32.0
> -----Original Message-----
> From: Colin King <[email protected]>
> Sent: Friday, October 8, 2021 12:37 AM
> To: Pkshih <[email protected]>; Kalle Valo <[email protected]>; David S . Miller
> <[email protected]>; Jakub Kicinski <[email protected]>; [email protected];
> [email protected]
> Cc: [email protected]; [email protected]
> Subject: [PATCH] rtlwifi: rtl8192ee: Remove redundant initialization of variable version
>
> From: Colin Ian King <[email protected]>
>
> The variable version is being initialized with a value that is
> never read, it is being updated afterwards in both branches of
> an if statement. The assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/hw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/hw.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/hw.c
> index 88fa2e593fef..76189283104c 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/hw.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/hw.c
> @@ -1430,7 +1430,7 @@ static enum version_8192e _rtl92ee_read_chip_version(struct ieee80211_hw
> *hw)
> {
> struct rtl_priv *rtlpriv = rtl_priv(hw);
> struct rtl_phy *rtlphy = &rtlpriv->phy;
> - enum version_8192e version = VERSION_UNKNOWN;
> + enum version_8192e version;
> u32 value32;
>
> rtlphy->rf_type = RF_2T2R;
> --
> 2.32.0
>
> ------Please consider the environment before printing this e-mail.
Acked-by: Ping-Ke Shih <[email protected]>
Colin King <[email protected]> wrote:
> From: Colin Ian King <[email protected]>
>
> The variable version is being initialized with a value that is
> never read, it is being updated afterwards in both branches of
> an if statement. The assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>
> Acked-by: Ping-Ke Shih <[email protected]>
Patch applied to wireless-drivers-next.git, thanks.
51fd5c6417b9 rtlwifi: rtl8192ee: Remove redundant initialization of variable version
--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches