2021-10-16 19:17:20

by Colin King

[permalink] [raw]
Subject: [PATCH][next] rtw89: Remove redundant check of ret after call to rtw89_mac_enable_bb_rf

From: Colin Ian King <[email protected]>

The function rtw89_mac_enable_bb_rf is a void return type, so there is
no return error code to ret, so the following check for an error in ret
is redundant dead code and can be removed.

Addresses-Coverity: ("Logically dead code")
Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/wireless/realtek/rtw89/mac.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtw89/mac.c b/drivers/net/wireless/realtek/rtw89/mac.c
index 0171a5a7b1de..69384c43c046 100644
--- a/drivers/net/wireless/realtek/rtw89/mac.c
+++ b/drivers/net/wireless/realtek/rtw89/mac.c
@@ -2656,8 +2656,6 @@ int rtw89_mac_init(struct rtw89_dev *rtwdev)
goto fail;

rtw89_mac_enable_bb_rf(rtwdev);
- if (ret)
- goto fail;

ret = rtw89_mac_sys_init(rtwdev);
if (ret)
--
2.32.0


2021-10-18 03:47:47

by Ping-Ke Shih

[permalink] [raw]
Subject: RE: [PATCH][next] rtw89: Remove redundant check of ret after call to rtw89_mac_enable_bb_rf


> -----Original Message-----
> From: Colin King <[email protected]>
> Sent: Friday, October 15, 2021 11:21 PM
> To: Kalle Valo <[email protected]>; David S . Miller <[email protected]>; Jakub Kicinski
> <[email protected]>; Pkshih <[email protected]>; [email protected];
> [email protected]
> Cc: [email protected]; [email protected]
> Subject: [PATCH][next] rtw89: Remove redundant check of ret after call to rtw89_mac_enable_bb_rf
>
> From: Colin Ian King <[email protected]>
>
> The function rtw89_mac_enable_bb_rf is a void return type, so there is
> no return error code to ret, so the following check for an error in ret
> is redundant dead code and can be removed.
>
> Addresses-Coverity: ("Logically dead code")
> Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
> Signed-off-by: Colin Ian King <[email protected]>

Acked-by: Ping-Ke Shih <[email protected]>

> ---
> drivers/net/wireless/realtek/rtw89/mac.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw89/mac.c
> b/drivers/net/wireless/realtek/rtw89/mac.c
> index 0171a5a7b1de..69384c43c046 100644
> --- a/drivers/net/wireless/realtek/rtw89/mac.c
> +++ b/drivers/net/wireless/realtek/rtw89/mac.c
> @@ -2656,8 +2656,6 @@ int rtw89_mac_init(struct rtw89_dev *rtwdev)
> goto fail;
>
> rtw89_mac_enable_bb_rf(rtwdev);
> - if (ret)
> - goto fail;
>
> ret = rtw89_mac_sys_init(rtwdev);
> if (ret)
> --
> 2.32.0
>
> ------Please consider the environment before printing this e-mail.

2021-10-18 12:32:24

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH][next] rtw89: Remove redundant check of ret after call to rtw89_mac_enable_bb_rf

Colin King <[email protected]> wrote:

> From: Colin Ian King <[email protected]>
>
> The function rtw89_mac_enable_bb_rf is a void return type, so there is
> no return error code to ret, so the following check for an error in ret
> is redundant dead code and can be removed.
>
> Addresses-Coverity: ("Logically dead code")
> Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
> Signed-off-by: Colin Ian King <[email protected]>
> Acked-by: Ping-Ke Shih <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

f7e7e440550b rtw89: Remove redundant check of ret after call to rtw89_mac_enable_bb_rf

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches