2021-12-08 06:27:58

by David Mosberger-Tang

Subject: [PATCH] wilc1000: Fix spurious "FW not responding" error

When deinitializing the driver, one or more "FW not responding" error
appears on the console. This appears to be due to wilc_wlan_stop()
disabling host/WILC1000 communication, but then right afterwards, it
tries to release the bus with chip-sleep enabled. The problem is
enabling the chip-sleep cannot success once host/WILC1000
communication is disabled. Fix by only releasing the bus.

Signed-off-by: David Mosberger-Tang <[email protected]>
---
drivers/net/wireless/microchip/wilc1000/wlan.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/microchip/wilc1000/wlan.c b/drivers/net/wireless/microchip/wilc1000/wlan.c
index f1e4ac3a2ad5..5d7f5b52f6de 100644
--- a/drivers/net/wireless/microchip/wilc1000/wlan.c
+++ b/drivers/net/wireless/microchip/wilc1000/wlan.c
@@ -1224,7 +1224,8 @@ int wilc_wlan_stop(struct wilc *wilc, struct wilc_vif *vif)

ret = 0;
release:
- release_bus(wilc, WILC_BUS_RELEASE_ALLOW_SLEEP);
+ /* host comm is disabled - we can't issue sleep command anymore: */
+ release_bus(wilc, WILC_BUS_RELEASE_ONLY);

return ret;
}
--
2.25.1

2021-12-14 18:45:40

by Kalle Valo

Subject: Re: [PATCH] wilc1000: Fix spurious "FW not responding" error

David Mosberger-Tang <[email protected]> wrote:

> When deinitializing the driver, one or more "FW not responding" error
> appears on the console. This appears to be due to wilc_wlan_stop()
> disabling host/WILC1000 communication, but then right afterwards, it
> tries to release the bus with chip-sleep enabled. The problem is
> enabling the chip-sleep cannot success once host/WILC1000
> communication is disabled. Fix by only releasing the bus.
>
> Signed-off-by: David Mosberger-Tang <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

73bbef64bca7 wilc1000: Fix spurious "FW not responding" error

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches